public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH v3] elf: Set p_align to the minimum page size if possible
Date: Fri, 14 Jan 2022 09:27:35 +0100	[thread overview]
Message-ID: <11e134a2-1ee7-bec4-fa03-1d76609923f7@suse.com> (raw)
In-Reply-To: <20211229193949.146079-1-hjl.tools@gmail.com>

On 29.12.2021 20:39, H.J. Lu via Binutils wrote:
> --- a/ld/testsuite/ld-elf/linux-x86.exp
> +++ b/ld/testsuite/ld-elf/linux-x86.exp
> @@ -185,6 +185,42 @@ run_ld_link_exec_tests [list \
>  	"" \
>  	"tmpdir/indirect-extern-access-2.so" \
>      ] \
> +    [list \
> +	"Run p_align-1a without PIE" \
> +	"$NOPIE_LDFLAGS" \
> +	"" \
> +	{ p_align-1.c } \
> +	"p_align-1a" \
> +	"pass.out" \
> +	"$NOPIE_CFLAGS" \
> +    ] \
> +    [list \
> +	"Run p_align-1b with PIE" \
> +	"-pie" \
> +	"" \
> +	{ p_align-1.c } \
> +	"p_align-1b" \
> +	"pass.out" \
> +	"-fpie" \
> +    ] \
> +    [list \
> +	"Run p_align-1c with -Wl,-z,max-page-size=0x1000 without PIE" \
> +	"$NOPIE_LDFLAGS -Wl,-z,max-page-size=0x1000" \
> +	"" \
> +	{ p_align-1.c } \
> +	"p_align-1c" \
> +	"pass.out" \
> +	"$NOPIE_CFLAGS" \
> +    ] \
> +    [list \
> +	"Run p_align-1d with -Wl,-z,max-page-size=0x1000 with PIE" \
> +	"-pie -Wl,-z,max-page-size=0x1000" \
> +	"" \
> +	{ p_align-1.c } \
> +	"p_align-1d" \
> +	"pass.out" \
> +	"-fpie" \
> +    ] \
>  ]

The two PIE variants of this also fail for me on glibc 2.26. Looks
like LOAD segments' alignment isn't being honored there, at least
not if it's as big as it is here.

Jan


  parent reply	other threads:[~2022-01-14  8:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-29 19:39 H.J. Lu
2022-01-14  8:12 ` Jan Beulich
2022-02-10 12:44   ` Jan Beulich
2022-01-14  8:27 ` Jan Beulich [this message]
2022-01-14 13:03   ` H.J. Lu
2022-01-14 13:40     ` Jan Beulich
2022-01-14 14:02       ` H.J. Lu
2022-01-14 14:07         ` Jan Beulich
2022-01-14 14:14           ` H.J. Lu
2022-01-17 10:38             ` Jan Beulich
2022-01-17 13:44               ` [PATCH] ld: Require GCC 8.0 for p_align-1.c tests H.J. Lu
2022-01-17 13:51                 ` Jan Beulich
2022-01-17 13:54                   ` H.J. Lu
  -- strict thread matches above, loose matches on Subject: below --
2021-12-25  3:54 [PATCH v3] elf: Set p_align to the minimum page size if possible H.J. Lu
2021-12-29  0:42 ` Alan Modra
2021-12-29 19:41   ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11e134a2-1ee7-bec4-fa03-1d76609923f7@suse.com \
    --to=jbeulich@suse.com \
    --cc=binutils@sourceware.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).