From: "H.J. Lu" <hjl.tools@gmail.com>
To: Alan Modra <amodra@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH v3] elf: Set p_align to the minimum page size if possible
Date: Wed, 29 Dec 2021 11:41:31 -0800 [thread overview]
Message-ID: <CAMe9rOovU802+bqsZ25nzb91MNQ8ruiwu1gm_Hxu38xGZBdt2w@mail.gmail.com> (raw)
In-Reply-To: <YcuvEOIB5TfXSlLA@squeak.grove.modra.org>
On Tue, Dec 28, 2021 at 4:43 PM Alan Modra <amodra@gmail.com> wrote:
>
> On Fri, Dec 24, 2021 at 07:54:18PM -0800, H.J. Lu via Binutils wrote:
> > Changes in v3:
> >
> > 1. To enable this linker optimization, the backend must define ELF_P_ALIGN
> > to ELF_MINPAGESIZE.
>
> All this means is that you're only breaking x86 binaries for those
> with older glibc who might be running with page size larger than 4k.
Correct.
> If this isn't so, what am I missing?
>
> Also, please check for fallout in future.
>
> alpha-linux +FAIL: ld-elf/pr26936
> alpha-linux +FAIL: ld-elf/seg
> alpha-linux +FAIL: rgn-at5
> alpha-netbsd +FAIL: ld-elf/pr26936
> alpha-unknown-freebsd4.7 +FAIL: ld-elf/pr26936
> arc-elf +FAIL: ld-elf/pr26936
> arc-linux-uclibc +FAIL: ld-elf/pr26936
> arc-linux-uclibc +FAIL: ld-elf/seg
> arc-linux-uclibc +FAIL: rgn-at5
> arm-nacl +FAIL: ld-elf/pr26936
> avr-elf +FAIL: ld-scripts/pr23571
> cr16-elf +FAIL: ld-scripts/pr23571
> cris-linux +FAIL: ld-elf/pr26936
> cris-linux +FAIL: ld-elf/seg
> cris-linux +FAIL: rgn-at5
> crisv32-linux +FAIL: ld-elf/pr26936
> crisv32-linux +FAIL: ld-elf/seg
> crisv32-linux +FAIL: rgn-at5
> crx-elf +FAIL: ld-scripts/pr23571
> frv-linux +FAIL: ld-elf/pr26936
> frv-linux +FAIL: ld-elf/seg
> frv-linux +FAIL: rgn-at5
> h8300-elf +FAIL: ld-scripts/pr23571
> h8300-linux +FAIL: ld-scripts/pr23571
> ia64-elf +FAIL: ld-elf/pr26936
> ia64-freebsd5 +FAIL: ld-elf/pr26936
> ia64-linux +FAIL: ld-elf/pr26936
> ia64-linux +FAIL: ld-elf/seg
> ia64-linux +FAIL: rgn-at5
> ia64-netbsd +FAIL: ld-elf/pr26936
> ip2k-elf +FAIL: ld-scripts/pr23571
> lm32-linux +FAIL: ld-elf/pr26936
> lm32-linux +FAIL: ld-elf/seg
> lm32-linux +FAIL: rgn-at5
> loongarch64-linux +FAIL: ld-elf/seg
> loongarch64-linux +FAIL: rgn-at5
> m32c-elf +FAIL: ld-scripts/pr23571
> m32r-elf +FAIL: ld-scripts/pr23571
> m68k-elf +FAIL: ld-elf/pr26936
> m68k-linux +FAIL: ld-elf/pr26936
> m68k-linux +FAIL: ld-elf/seg
> m68k-linux +FAIL: rgn-at5
> moxie-elf +FAIL: ld-scripts/pr23571
> nds32le-linux +FAIL: ld-elf/pr26936
> nds32le-linux +FAIL: ld-elf/seg
> nds32le-linux +FAIL: rgn-at5
> or1k-linux +FAIL: ld-elf/pr26936
> or1k-linux +FAIL: ld-elf/seg
> or1k-linux +FAIL: rgn-at5
> pru-elf +FAIL: pru_irq_map special section for host
> pru-elf +FAIL: ld-scripts/pr23571
> score-elf +FAIL: ld-elf/pr26936
> shle-unknown-netbsdelf +FAIL: ld-elf/pr26936
> sh-nto +FAIL: ld-scripts/pr23571
> sh-rtems +FAIL: ld-scripts/pr23571
> sparc64-linux +FAIL: ld-elf/pr26936
> sparc64-linux +FAIL: ld-elf/seg
> sparc64-linux +FAIL: rgn-at5
> sparc-elf +FAIL: ld-elf/pr26936
> sparc-linux +FAIL: ld-elf/pr26936
> sparc-linux +FAIL: ld-elf/seg
> sparc-linux +FAIL: rgn-at5
> sparc-sun-solaris2 +FAIL: ld-elf/pr26936
> spu-elf +FAIL: ld-scripts/pr23571
> tilegx-linux +FAIL: ld-elf/pr26936
> tilegx-linux +FAIL: ld-elf/seg
> tilegx-linux +FAIL: rgn-at5
> tilepro-linux +FAIL: ld-elf/pr26936
> tilepro-linux +FAIL: ld-elf/seg
> tilepro-linux +FAIL: rgn-at5
> visium-elf +FAIL: ld-scripts/pr23571
> xstormy16-elf +FAIL: ld-scripts/pr23571
I adjusted these tests in the v3 patch:
https://sourceware.org/pipermail/binutils/2021-December/119047.html
--
H.J.
next prev parent reply other threads:[~2021-12-29 19:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-25 3:54 H.J. Lu
2021-12-29 0:42 ` Alan Modra
2021-12-29 19:41 ` H.J. Lu [this message]
2021-12-29 19:39 H.J. Lu
2022-01-14 8:12 ` Jan Beulich
2022-02-10 12:44 ` Jan Beulich
2022-01-14 8:27 ` Jan Beulich
2022-01-14 13:03 ` H.J. Lu
2022-01-14 13:40 ` Jan Beulich
2022-01-14 14:02 ` H.J. Lu
2022-01-14 14:07 ` Jan Beulich
2022-01-14 14:14 ` H.J. Lu
2022-01-17 10:38 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOovU802+bqsZ25nzb91MNQ8ruiwu1gm_Hxu38xGZBdt2w@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).