public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Michael Morrell <morrell@alumni.ucsd.edu>
To: binutils@sourceware.org
Subject: Re: Commit: Gas: Add .nop directive.
Date: Mon, 14 Sep 2020 16:04:14 +0000 (UTC)	[thread overview]
Message-ID: <1396691708.4116097.1600099454135@mail.yahoo.com> (raw)
In-Reply-To: <mailman.151032.1600097231.8982.binutils@sourceware.org>

 Once this is in, I hope this code from gcc/configure can be removed:

# ??? Not all targets support dwarf2 debug_line, even within a version
# of gas. Moreover, we need to emit a valid instruction to trigger any
# info to the output file. So, as supported targets are added to gas 2.11,
# add some instruction here to (also) show we expect this might work.
# ??? Once 2.11 is released, probably need to add first known working
# version to the per-target configury.
case "$cpu_type" in
 aarch64 | alpha | arc | arm | avr | bfin | cris | csky | i386 | m32c | m68k \
 | microblaze | mips | nds32 | nios2 | pa | riscv | rs6000 | score | sparc | spu \
 | tilegx | tilepro | visium | xstormy16 | xtensa)
 insn="nop"
 ;;
 ia64 | s390)
 insn="nop 0"
 ;;
 mmix)
 insn="swym 0"
 ;;
esac

You currently have to update this for every new port to be able to check for dwarf2_debug_line support (even if the port has a "nop" instruction).

 Michael

On Monday, September 14, 2020, 08:27:15 AM PDT, Nick Clifton wrote:
 
Hi Guys,

 I am checking in the attached patch to add a ".nop" directive to the
 assembler. This directive creates a single no-op instruction. It is
 similar to the already existing ".nops" directive, apart from two
 important differences:

 1. It is implemented for all architectures, not just x86.
 2. The instruction it generates counts as a real instruction for the
 purposes of DWARF line number table generation.

 Fact 1 is important as it allows the directive to be used to generate
 architecture neutral test cases containing real instructions.

 Tested with a large variety of different targets.

Cheers
 Nick  

       reply	other threads:[~2020-09-14 16:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.151032.1600097231.8982.binutils@sourceware.org>
2020-09-14 16:04 ` Michael Morrell [this message]
2020-09-14 16:31   ` Nick Clifton
2020-09-15  3:52     ` 2.35.1 (was: Commit: Gas: Add .nop directive.) Hans-Peter Nilsson
2020-09-15 10:31       ` Nick Clifton
2020-09-15 11:47         ` Hans-Peter Nilsson
2020-09-15 12:45           ` Nick Clifton
2020-09-15  9:53     ` Commit: Gas: Add .nop directive Nick Clifton
2020-09-14 15:13 Nick Clifton
2020-09-14 15:27 ` Jose E. Marchesi
2020-09-15 11:13   ` Nick Clifton
2020-09-15 11:57     ` Jose E. Marchesi
2020-09-14 15:38 ` Andreas Schwab
2020-09-14 16:02   ` Nick Clifton
2020-09-30 18:18 ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396691708.4116097.1600099454135@mail.yahoo.com \
    --to=morrell@alumni.ucsd.edu \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).