From: Hans-Peter Nilsson <hp@bitrange.com>
To: Nick Clifton <nickc@redhat.com>
Cc: binutils@sourceware.org
Subject: Re: 2.35.1 (was: Commit: Gas: Add .nop directive.)
Date: Tue, 15 Sep 2020 07:47:01 -0400 (EDT) [thread overview]
Message-ID: <alpine.BSF.2.20.16.2009150729460.7949@arjuna.pair.com> (raw)
In-Reply-To: <0553fbc4-0990-b465-68b8-083558bd2755@redhat.com>
On Tue, 15 Sep 2020, Nick Clifton wrote:
> > PS. The new .nop test-case fails for mmix. It's "swym 0" if you beat me to the fix.
>
> It does ? I do not see any failures in my tests. Can you tell me how to reproduce the problem ?
On a brief inspection, it seems it's not a trivial overlooked
definition (thanks for caring), but instead some kind of
undefinedwilduninitialized thing. I get in gas.log, at
4a8f181d196f85ca1, for --target=mmix-knuth-mmixware on a
i686-linux host:
../as-new -o tmpdir/nop.o /home/hp/binutils/src/gas/testsuite/gas/all/nop.s
Executing on host: sh -c {../as-new -o tmpdir/nop.o /home/hp/binutils/src/gas/testsuite/gas/all/nop.s 2>&1} /dev/null dump.tmp (timeout = 300)
/home/hp/binutils/src/gas/testsuite/gas/all/nop.s: Assembler messages:
/home/hp/binutils/src/gas/testsuite/gas/all/nop.s:2: Error: junk at end of line, first unrecognized character valued 0x8
/home/hp/binutils/src/gas/testsuite/gas/all/nop.s:2: Error: unknown opcode: `XXXa'
/home/hp/binutils/src/gas/testsuite/gas/all/nop.s:2: Error: junk at end of line, first unrecognized character valued 0x14
/home/hp/binutils/src/gas/testsuite/gas/all/nop.s:2: Error: junk at end of line, first unrecognized character valued 0x14
/home/hp/binutils/src/gas/testsuite/gas/all/nop.s:3: Error: junk at end of line, first unrecognized character valued 0x14
/home/hp/binutils/src/gas/testsuite/gas/all/nop.s:3: Fatal error: internal: unhandled label
failed with: </home/hp/binutils/src/gas/testsuite/gas/all/nop.s: Assembler messages:
/home/hp/binutils/src/gas/testsuite/gas/all/nop.s:2: Error: junk at end of line, first unrecognized character valued 0x8
/home/hp/binutils/src/gas/testsuite/gas/all/nop.s:2: Error: unknown opcode: `XXXa'
/home/hp/binutils/src/gas/testsuite/gas/all/nop.s:2: Error: junk at end of line, first unrecognized character valued 0x14
/home/hp/binutils/src/gas/testsuite/gas/all/nop.s:2: Error: junk at end of line, first unrecognized character valued 0x14
/home/hp/binutils/src/gas/testsuite/gas/all/nop.s:3: Error: junk at end of line, first unrecognized character valued 0x14
/home/hp/binutils/src/gas/testsuite/gas/all/nop.s:3: Fatal error: internal: unhandled label >, no expected output
FAIL: Generate NOPs in an architecture neutral manner
The three characters marked XXX (which I didn't want to include
verbatim) are 0xbd, 0x14, 0x8.
On another host, x86_64-linux built with -m32, everything is
fine. Perhaps a valgrind and/or asan run will show (later).
brgds, H-P
PS. It should be "swym 0", not "set $0,$0". I'll fix.
next prev parent reply other threads:[~2020-09-15 11:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.151032.1600097231.8982.binutils@sourceware.org>
2020-09-14 16:04 ` Commit: Gas: Add .nop directive Michael Morrell
2020-09-14 16:31 ` Nick Clifton
2020-09-15 3:52 ` 2.35.1 (was: Commit: Gas: Add .nop directive.) Hans-Peter Nilsson
2020-09-15 10:31 ` Nick Clifton
2020-09-15 11:47 ` Hans-Peter Nilsson [this message]
2020-09-15 12:45 ` Nick Clifton
2020-09-15 9:53 ` Commit: Gas: Add .nop directive Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSF.2.20.16.2009150729460.7949@arjuna.pair.com \
--to=hp@bitrange.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).