From: Jan Beulich <jbeulich@suse.com>
To: Binutils <binutils@sourceware.org>
Subject: [PATCH 6/6] gas: avoid octal numbers being accepted when processing .linefile
Date: Fri, 6 May 2022 08:08:23 +0200 [thread overview]
Message-ID: <152c0e4f-4fef-1f10-e2de-dfdee829255e@suse.com> (raw)
In-Reply-To: <e96f677b-acf7-e5a9-e99e-48ae61a20da8@suse.com>
Compilers would put decimal numbers there, so I think we should treat
finding octal numbers the same as finding bignums - ignore them as
actually being comments of some very specific form.
---
With the bignum and this change in place, I'm still worried about the
secondary use of get_linefile_number() - afaict we might still
mistakenly try to process special form comments as line/file
"directives", and under the right conditions this might also still
result in unde diagnostics.
--- a/gas/read.c
+++ b/gas/read.c
@@ -2047,6 +2047,14 @@ get_linefile_number (int *flag)
if (*input_line_pointer < '0' || *input_line_pointer > '9')
return false;
+ /* Don't mistakenly interpret octal numbers as line numbers. */
+ if (*input_line_pointer == '0')
+ {
+ *flag = 0;
+ ++input_line_pointer;
+ return true;
+ }
+
expression_and_evaluate (&exp);
if (exp.X_op != O_constant)
return false;
--- a/gas/testsuite/gas/all/linefile.l
+++ b/gas/testsuite/gas/all/linefile.l
@@ -2,4 +2,5 @@
.*linefile\.s: Assembler messages:
.*linefile\.s:2: Warning: line 2
.*linefile\.s:5: Warning: line 5
+.*linefile\.s:8: Warning: line 8
#pass
--- a/gas/testsuite/gas/all/linefile.s
+++ b/gas/testsuite/gas/all/linefile.s
@@ -3,3 +3,6 @@
# 123456789123456789123456789 "LINEfile.s"
.warning "line 5"
+
+# 0123456789 "lineFILE.s"
+ .warning "line 8"
prev parent reply other threads:[~2022-05-06 6:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 6:04 [PATCH 0/6] gas: (mostly) further file/line handling adjustments Jan Beulich
2022-05-06 6:05 ` [PATCH 1/6] gas: tweak .irp and alike file/line handling for M68K/MRI Jan Beulich
2022-05-06 6:06 ` [PATCH 2/6] gas: simplify ignore_input() Jan Beulich
2022-05-06 6:06 ` [PATCH 3/6] gas: don't ignore .linefile inside false conditionals Jan Beulich
2022-05-06 6:07 ` [PATCH 4/6] gas: fold do_repeat{,_with_expander}() Jan Beulich
2022-05-06 6:08 ` [PATCH 5/6] gas: avoid bignum related errors when processing .linefile Jan Beulich
2022-05-06 6:08 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152c0e4f-4fef-1f10-e2de-dfdee829255e@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).