From: Jan Beulich <jbeulich@suse.com>
To: Jinyang He <hejinyang@loongson.cn>
Cc: Alan Modra <amodra@gmail.com>,
mengqinggang <mengqinggang@loongson.cn>,
binutils@sourceware.org, Xing Li <lixing@loongson.cn>,
Xi Ruoyao <xry111@xry111.site>
Subject: Re: [PATCH] Make sure DW_CFA_advance_loc4 is in the same frag
Date: Thu, 10 Aug 2023 14:55:20 +0200 [thread overview]
Message-ID: <17e42638-1b32-b7d5-7d85-3417b9375ba8@suse.com> (raw)
In-Reply-To: <8771969c-b332-c008-3e35-c37c6c420c6e@loongson.cn>
On 10.08.2023 14:36, Jinyang He wrote:
> On /Thu Aug 10 07:55:58 GMT 2023 /Jan Beulich wrote:
>
>> On 10.08.2023 04:21, Jinyang He wrote:
>>> /The DW_CFA_advance_loc4 may be in different frags. Then fr_fix />/may caused something wrong. Referenced by commit b9d8f5601bcf />/("Re: Optimise away eh_frame advance_loc 0"). /
>> I'm afraid I don't understand that earlier fix: frag_more(1) there
>> ought to guarantee fr_fix (once the frag is closed) to be >= 1.
>> It would then seem to me that ...
>
> I'm not familiar with it. Please point out my mistakes. Thanks in advance.
Well, Alan has approved your change. Maybe it's me who is wrong here.
Jan
next prev parent reply other threads:[~2023-08-10 12:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ab826dcb-6969-a980-889a-6958b60a4b48@loongson.cn>
2023-08-10 12:36 ` Jinyang He
2023-08-10 12:55 ` Jan Beulich [this message]
2023-08-10 23:02 ` Alan Modra
2023-08-11 8:27 ` Jan Beulich
2023-08-11 10:15 ` Alan Modra
2023-08-30 3:35 ` Jinyang He
2023-08-30 6:28 ` Jan Beulich
2023-09-08 23:46 ` Alan Modra
2023-08-10 2:21 Jinyang He
2023-08-10 7:51 ` Alan Modra
2023-08-10 7:55 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17e42638-1b32-b7d5-7d85-3417b9375ba8@suse.com \
--to=jbeulich@suse.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=hejinyang@loongson.cn \
--cc=lixing@loongson.cn \
--cc=mengqinggang@loongson.cn \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).