public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jinyang He <hejinyang@loongson.cn>
To: Nick Clifton <nickc@redhat.com>, mengqinggang <mengqinggang@loongson.cn>
Cc: binutils@sourceware.org, Xing Li <lixing@loongson.cn>,
	Xi Ruoyao <xry111@xry111.site>
Subject: [PATCH] Make sure DW_CFA_advance_loc4 is in the same frag
Date: Thu, 10 Aug 2023 10:21:40 +0800	[thread overview]
Message-ID: <20230810022140.3030-1-hejinyang@loongson.cn> (raw)

The DW_CFA_advance_loc4 may be in different frags. Then fr_fix
may caused something wrong. Referenced by commit b9d8f5601bcf
("Re: Optimise away eh_frame advance_loc 0").

gas/ChangeLog:

	* ehopt.c (check_eh_frame): Don't allow DW_CFA_advance_loc4
	to be placed in a different frag to the rs_cfa.
---
BTW, it is a bug I triggered when compiling a LoongArch.asm file with
relaxation being enabled. I hope it could be merged to 2.41 as bug-fix.
 
 gas/ehopt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gas/ehopt.c b/gas/ehopt.c
index feea61b92..9d6606adf 100644
--- a/gas/ehopt.c
+++ b/gas/ehopt.c
@@ -386,7 +386,7 @@ check_eh_frame (expressionS *exp, unsigned int *pnbytes)
 	{
 	  /* This might be a DW_CFA_advance_loc4.  Record the frag and the
 	     position within the frag, so that we can change it later.  */
-	  frag_grow (1);
+	  frag_grow (1 + 4);
 	  d->state = state_saw_loc4;
 	  d->loc4_frag = frag_now;
 	  d->loc4_fix = frag_now_fix ();
-- 
2.34.3


             reply	other threads:[~2023-08-10  2:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10  2:21 Jinyang He [this message]
2023-08-10  7:51 ` Alan Modra
2023-08-10  7:55 ` Jan Beulich
     [not found] <ab826dcb-6969-a980-889a-6958b60a4b48@loongson.cn>
2023-08-10 12:36 ` Jinyang He
2023-08-10 12:55   ` Jan Beulich
2023-08-10 23:02     ` Alan Modra
2023-08-11  8:27       ` Jan Beulich
2023-08-11 10:15         ` Alan Modra
2023-08-30  3:35           ` Jinyang He
2023-08-30  6:28             ` Jan Beulich
2023-09-08 23:46               ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230810022140.3030-1-hejinyang@loongson.cn \
    --to=hejinyang@loongson.cn \
    --cc=binutils@sourceware.org \
    --cc=lixing@loongson.cn \
    --cc=mengqinggang@loongson.cn \
    --cc=nickc@redhat.com \
    --cc=xry111@xry111.site \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).