* [PATCH v1] LoongArch: Run overflow testcases only on LoongArch target
@ 2024-02-27 7:17 mengqinggang
2024-02-27 18:40 ` Fangrui Song
[not found] ` <DS7PR12MB57652CF22FECDFF41C99AE90CB592@DS7PR12MB5765.namprd12.prod.outlook.com>
0 siblings, 2 replies; 3+ messages in thread
From: mengqinggang @ 2024-02-27 7:17 UTC (permalink / raw)
To: binutils
Cc: xuchenghua, chenglulu, liuzhensong, cailulu, xry111, i.swmail,
maskray, luweining, wanglei, hejinyang, mengqinggang
---
.../ld-loongarch-elf/ld-loongarch-elf.exp | 27 ++++++++++---------
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp b/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
index 3a8629a07df..27310fe1275 100644
--- a/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
+++ b/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
@@ -133,18 +133,19 @@ if [istarget "loongarch64-*-*"] {
run_dump_test "desc-norelax"
run_dump_test "desc-relax"
}
+
+ run_dump_test "max_imm_b16"
+ run_dump_test "max_imm_b21"
+ run_dump_test "max_imm_b26"
+ run_dump_test "max_imm_pcrel20"
+ run_dump_test "overflow_b16"
+ run_dump_test "overflow_b21"
+ run_dump_test "overflow_b26"
+ run_dump_test "overflow_pcrel20"
+ run_dump_test "underflow_b16"
+ run_dump_test "underflow_b21"
+ run_dump_test "underflow_b26"
+ run_dump_test "underflow_pcrel20"
+ run_dump_test "pie_discard"
}
-run_dump_test "max_imm_b16"
-run_dump_test "max_imm_b21"
-run_dump_test "max_imm_b26"
-run_dump_test "max_imm_pcrel20"
-run_dump_test "overflow_b16"
-run_dump_test "overflow_b21"
-run_dump_test "overflow_b26"
-run_dump_test "overflow_pcrel20"
-run_dump_test "underflow_b16"
-run_dump_test "underflow_b21"
-run_dump_test "underflow_b26"
-run_dump_test "underflow_pcrel20"
-run_dump_test "pie_discard"
--
2.36.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] LoongArch: Run overflow testcases only on LoongArch target
2024-02-27 7:17 [PATCH v1] LoongArch: Run overflow testcases only on LoongArch target mengqinggang
@ 2024-02-27 18:40 ` Fangrui Song
[not found] ` <DS7PR12MB57652CF22FECDFF41C99AE90CB592@DS7PR12MB5765.namprd12.prod.outlook.com>
1 sibling, 0 replies; 3+ messages in thread
From: Fangrui Song @ 2024-02-27 18:40 UTC (permalink / raw)
To: mengqinggang
Cc: binutils, xuchenghua, chenglulu, liuzhensong, cailulu, xry111,
i.swmail, maskray, luweining, wanglei, hejinyang
On Mon, Feb 26, 2024 at 11:17 PM mengqinggang <mengqinggang@loongson.cn> wrote:
>
> ---
> .../ld-loongarch-elf/ld-loongarch-elf.exp | 27 ++++++++++---------
> 1 file changed, 14 insertions(+), 13 deletions(-)
>
> diff --git a/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp b/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
> index 3a8629a07df..27310fe1275 100644
> --- a/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
> +++ b/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
> @@ -133,18 +133,19 @@ if [istarget "loongarch64-*-*"] {
> run_dump_test "desc-norelax"
> run_dump_test "desc-relax"
> }
> +
> + run_dump_test "max_imm_b16"
> + run_dump_test "max_imm_b21"
> + run_dump_test "max_imm_b26"
> + run_dump_test "max_imm_pcrel20"
> + run_dump_test "overflow_b16"
> + run_dump_test "overflow_b21"
> + run_dump_test "overflow_b26"
> + run_dump_test "overflow_pcrel20"
> + run_dump_test "underflow_b16"
> + run_dump_test "underflow_b21"
> + run_dump_test "underflow_b26"
> + run_dump_test "underflow_pcrel20"
> + run_dump_test "pie_discard"
> }
>
> -run_dump_test "max_imm_b16"
> -run_dump_test "max_imm_b21"
> -run_dump_test "max_imm_b26"
> -run_dump_test "max_imm_pcrel20"
> -run_dump_test "overflow_b16"
> -run_dump_test "overflow_b21"
> -run_dump_test "overflow_b26"
> -run_dump_test "overflow_pcrel20"
> -run_dump_test "underflow_b16"
> -run_dump_test "underflow_b21"
> -run_dump_test "underflow_b26"
> -run_dump_test "underflow_pcrel20"
> -run_dump_test "pie_discard"
> --
> 2.36.0
>
Combining these tests in one file would be much nicer (e.g.
https://github.com/MaskRay/llvm-project/blob/main/lld/test/ELF/systemz-reloc-disp12.s)
I wish that someone will implement
https://sourceware.org/bugzilla/show_bug.cgi?id=28602
("binutils/testsuite/lib/binutils-common.exp: Support free-form shell
commands and check patterns")
It takes some effort to implement this new framework and integrate it
into DejaGnu, but the long term benefit will be huge.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] LoongArch: Run overflow testcases only on LoongArch target
[not found] ` <DS7PR12MB57652CF22FECDFF41C99AE90CB592@DS7PR12MB5765.namprd12.prod.outlook.com>
@ 2024-02-29 1:23 ` mengqinggang
0 siblings, 0 replies; 3+ messages in thread
From: mengqinggang @ 2024-02-29 1:23 UTC (permalink / raw)
To: Fangrui Song
Cc: binutils, xuchenghua, chenglulu, liuzhensong, cailulu, xry111,
i.swmail, maskray, luweining, wanglei, hejinyang
Thanks, I will have a try.
在 2024/2/28 上午2:40, Fangrui Song 写道:
> On Mon, Feb 26, 2024 at 11:17 PM mengqinggang <mengqinggang@loongson.cn> wrote:
>> ---
>> .../ld-loongarch-elf/ld-loongarch-elf.exp | 27 ++++++++++---------
>> 1 file changed, 14 insertions(+), 13 deletions(-)
>>
>> diff --git a/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp b/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
>> index 3a8629a07df..27310fe1275 100644
>> --- a/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
>> +++ b/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
>> @@ -133,18 +133,19 @@ if [istarget "loongarch64-*-*"] {
>> run_dump_test "desc-norelax"
>> run_dump_test "desc-relax"
>> }
>> +
>> + run_dump_test "max_imm_b16"
>> + run_dump_test "max_imm_b21"
>> + run_dump_test "max_imm_b26"
>> + run_dump_test "max_imm_pcrel20"
>> + run_dump_test "overflow_b16"
>> + run_dump_test "overflow_b21"
>> + run_dump_test "overflow_b26"
>> + run_dump_test "overflow_pcrel20"
>> + run_dump_test "underflow_b16"
>> + run_dump_test "underflow_b21"
>> + run_dump_test "underflow_b26"
>> + run_dump_test "underflow_pcrel20"
>> + run_dump_test "pie_discard"
>> }
>>
>> -run_dump_test "max_imm_b16"
>> -run_dump_test "max_imm_b21"
>> -run_dump_test "max_imm_b26"
>> -run_dump_test "max_imm_pcrel20"
>> -run_dump_test "overflow_b16"
>> -run_dump_test "overflow_b21"
>> -run_dump_test "overflow_b26"
>> -run_dump_test "overflow_pcrel20"
>> -run_dump_test "underflow_b16"
>> -run_dump_test "underflow_b21"
>> -run_dump_test "underflow_b26"
>> -run_dump_test "underflow_pcrel20"
>> -run_dump_test "pie_discard"
>> --
>> 2.36.0
>>
> Combining these tests in one file would be much nicer (e.g.
> https://github.com/MaskRay/llvm-project/blob/main/lld/test/ELF/systemz-reloc-disp12.s)
> I wish that someone will implement
> https://sourceware.org/bugzilla/show_bug.cgi?id=28602
> ("binutils/testsuite/lib/binutils-common.exp: Support free-form shell
> commands and check patterns")
>
> It takes some effort to implement this new framework and integrate it
> into DejaGnu, but the long term benefit will be huge.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-29 1:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-27 7:17 [PATCH v1] LoongArch: Run overflow testcases only on LoongArch target mengqinggang
2024-02-27 18:40 ` Fangrui Song
[not found] ` <DS7PR12MB57652CF22FECDFF41C99AE90CB592@DS7PR12MB5765.namprd12.prod.outlook.com>
2024-02-29 1:23 ` mengqinggang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).