Re: [PATCH] LoongArch: Set defaults to exec stack 0.

[Xi Ruoyao <xry111@xry111.site>]

On Mon, 2022-07-25 at 10:24 +0800, WANG Xuerui wrote:
> On 2022/7/25 10:22, liuzhensong wrote:
> > ---
> >   bfd/elfnn-loongarch.c       | 1 +
> >   ld/testsuite/ld-elf/elf.exp | 1 +
> >   2 files changed, 2 insertions(+)
> > 
> > diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
> > index 4efe3d9370c..43182ead8cd 100644
> > --- a/bfd/elfnn-loongarch.c
> > +++ b/bfd/elfnn-loongarch.c
> > @@ -132,6 +132,7 @@ struct loongarch_elf_link_hash_table
> >   
> >   #define elf_backend_want_dynrelro 1
> >   #define elf_backend_rela_normal 1
> > +#define elf_backend_default_execstack 0
> >   
> >   /* Generate a PLT header.  */
> >   
> > diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-
> > elf/elf.exp
> > index 10c635e9593..b8829b4e3ee 100644
> > --- a/ld/testsuite/ld-elf/elf.exp
> > +++ b/ld/testsuite/ld-elf/elf.exp
> > @@ -187,6 +187,7 @@ proc target_defaults_to_execstack {} {
> >         || [istarget "nios2*-*-*"]
> >         || [istarget "powerpc64*-*-*"]
> >         || [istarget "riscv*-*-*"]
> > +       || [istarget "loongarch*-*-*"]
> >         || [istarget "tilegx*-*-*"]
> >         || [istarget "tilepro*-*-*"] } {
> >           return 0
> Looks good to me. I don't know why this isn't the case from the 
> beginning... I'll test on Gentoo shortly after.

I guess it's just noticed recently because ld has started to emit
warning for assembly inputs w/o .note.GNU-stack section.  Before the
warning the only way to notice this problem is "process xxx is started
with executable stack" in the kernel log if someone forgot to add a
.note.GNU-stack section in the assembly source file.

-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University