From: Andreas Schwab <schwab@suse.de>
To: liuzhensong <liuzhensong@loongson.cn>
Cc: binutils@sourceware.org, maskray@google.com,
caiyinyu@loongson.cn, xuchenghua@loongson.cn,
chenglulu@loongson.cn
Subject: Re: [PATCH] LoongArch: Set defaults to exec stack 0.
Date: Mon, 25 Jul 2022 10:08:30 +0200 [thread overview]
Message-ID: <mvmilnlmx6p.fsf@suse.de> (raw)
In-Reply-To: <20220725022227.16266-1-liuzhensong@loongson.cn> (liuzhensong@loongson.cn's message of "Mon, 25 Jul 2022 10:22:27 +0800")
On Jul 25 2022, liuzhensong wrote:
> diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
> index 4efe3d9370c..43182ead8cd 100644
> --- a/bfd/elfnn-loongarch.c
> +++ b/bfd/elfnn-loongarch.c
> @@ -132,6 +132,7 @@ struct loongarch_elf_link_hash_table
>
> #define elf_backend_want_dynrelro 1
> #define elf_backend_rela_normal 1
> +#define elf_backend_default_execstack 0
AFAICS, the loongarch kernel defaults to executable stack:
arch/loongarch/include/asm/elf.h:#define elf_read_implies_exec(ex, exec_stk) (exec_stk == EXSTACK_DEFAULT)
Which means this change is wrong.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2022-07-25 8:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 2:22 liuzhensong
2022-07-25 2:24 ` WANG Xuerui
2022-07-25 2:44 ` Xi Ruoyao
2022-07-25 7:51 ` Fangrui Song
2022-07-25 8:08 ` Andreas Schwab [this message]
2022-07-25 8:14 ` Xi Ruoyao
2022-07-25 8:35 ` Andreas Schwab
2022-07-25 9:17 ` WANG Xuerui
2022-07-25 9:18 ` Huacai Chen
2022-07-25 9:22 ` Xi Ruoyao
2022-07-25 9:44 ` WANG Xuerui
2022-07-30 19:20 ` WANG Xuerui
2022-08-01 1:10 ` liuzhensong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmilnlmx6p.fsf@suse.de \
--to=schwab@suse.de \
--cc=binutils@sourceware.org \
--cc=caiyinyu@loongson.cn \
--cc=chenglulu@loongson.cn \
--cc=liuzhensong@loongson.cn \
--cc=maskray@google.com \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).