* Re: [PATCH] Addition of new option '--rlib' in linker for Renesas SH targets
@ 2006-07-04 8:21 Gina Verlekar
2006-07-04 11:24 ` Dave Korn
0 siblings, 1 reply; 13+ messages in thread
From: Gina Verlekar @ 2006-07-04 8:21 UTC (permalink / raw)
To: Pedro Alves; +Cc: binutils
Hi,
>You could instead have (simplified):
>rlibextract $(renesaslib) $(outputdir)
>ar q librenlib.a $(outputdir)/*
>ld $(objects) -lrenlib
>rlibextract being your new tool.
>It would reduce code duplication,
>you would be able to maintain it with a different release cycle from
>binutils,
>*and* it could be used with older binutils versions.
>Wouldn't this be better? Or am I missing something?
Thank you for your suggestion.
We agree to you that a separate utility to generate a GNU archive from
Renesas library file is better idea. We will surely implement it. It
would
be better to invoke "ar" internally from this utility. This will help
user
to get GNU archive directly.
Regards,
Gina Verlekar
KPIT Cummins InfoSystems Ltd.
Pune, India
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Free download of GNU based tool-chains for Renesas SH, H8, R8C, M16C and
M32C Series.
The following site also offers free technical support to its users.
Visit http://www.kpitgnutools.com for details.
Latest versions of KPIT GNU tools were released on June 1, 2006.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] Addition of new option '--rlib' in linker for Renesas SH targets
2006-07-04 8:21 [PATCH] Addition of new option '--rlib' in linker for Renesas SH targets Gina Verlekar
@ 2006-07-04 11:24 ` Dave Korn
2006-07-07 8:51 ` Gina Verlekar
0 siblings, 1 reply; 13+ messages in thread
From: Dave Korn @ 2006-07-04 11:24 UTC (permalink / raw)
To: 'Gina Verlekar', 'Pedro Alves'; +Cc: binutils
On 04 July 2006 09:21, Gina Verlekar wrote:
> Hi,
>
>> You could instead have (simplified):
>
>> rlibextract $(renesaslib) $(outputdir)
>> ar q librenlib.a $(outputdir)/*
>> ld $(objects) -lrenlib
>
>> rlibextract being your new tool.
>> It would reduce code duplication,
>> you would be able to maintain it with a different release cycle from
>> binutils, *and* it could be used with older binutils versions.
>> Wouldn't this be better? Or am I missing something?
>
> Thank you for your suggestion.
> We agree to you that a separate utility to generate a GNU archive from
> Renesas library file is better idea. We will surely implement it. It
> would
> be better to invoke "ar" internally from this utility. This will help
> user
> to get GNU archive directly.
And of course, if there's a new release of binutils with a new improved
version of ar, your utility benefits automatically, without needing to
maintain the code you were going to add separately! :)
cheers,
DaveK
--
Can't think of a witty .sigline today....
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] Addition of new option '--rlib' in linker for Renesas SH targets
2006-07-04 11:24 ` Dave Korn
@ 2006-07-07 8:51 ` Gina Verlekar
0 siblings, 0 replies; 13+ messages in thread
From: Gina Verlekar @ 2006-07-07 8:51 UTC (permalink / raw)
To: Dave Korn, Pedro Alves; +Cc: binutils
[-- Attachment #1: Type: text/plain, Size: 3021 bytes --]
Hi,
The patch attached herewith adds a new utility 'convrenesaslib'. This
utility
converts the input Renesas SH library file(s) to GNU archive file(s).
This utility supports only Renesas SH library files. Multiple Renesas
library
files can be provided on command line at a time.
The usage of this utility is as follows:
convrenesaslib filename(s)
where 'filename' is the input Renesas SH library file.
The GNU archive which gets created has '.rlib' extension. This file is
created
in the same directory as the Renesas library file.
An option '--remove-underscore' is provided to this utility.
Usage:
convrenesaslib --remove-underscore filename(s)
--remove-underscore
This will remove all leading underscores appended to global symbols
in
the created GNU archive.
Changelog
2006-07-07 Gina G. Verlekar <ginav@kpitcummins.com>
* convrenesaslib.c: Add new file
* Makefile.in: Modify to build convrenesaslib.c.
* Makefile.am: Likewise.
* configure.in: Check for Renesas SH targets to build
convrenesaslib.
* doc/binutils.texi: Add documentation for convrenesaslib
utility.
Any comments will be appreciated.
Regards,
Gina Verlekar
KPIT Cummins InfoSystems Ltd.
Pune, India
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Free download of GNU based tool-chains for Renesas SH, H8, R8C, M16C and
M32C
Series.
The following site also offers free technical support to its users.
Visit http://www.kpitgnutools.com for details.
Latest versions of KPIT GNU tools were released on June 1, 2006.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-----Original Message-----
From: Dave Korn [mailto:dave.korn@artimi.com]
Sent: Tuesday, July 04, 2006 4:54 PM
To: Gina Verlekar; 'Pedro Alves'
Cc: binutils@sourceware.org
Subject: RE: [PATCH] Addition of new option '--rlib' in linker for
Renesas SH targets
On 04 July 2006 09:21, Gina Verlekar wrote:
> Hi,
>
>> You could instead have (simplified):
>
>> rlibextract $(renesaslib) $(outputdir)
>> ar q librenlib.a $(outputdir)/*
>> ld $(objects) -lrenlib
>
>> rlibextract being your new tool.
>> It would reduce code duplication,
>> you would be able to maintain it with a different release cycle from
>> binutils, *and* it could be used with older binutils versions.
>> Wouldn't this be better? Or am I missing something?
>
> Thank you for your suggestion.
> We agree to you that a separate utility to generate a GNU archive from
> Renesas library file is better idea. We will surely implement it. It
> would
> be better to invoke "ar" internally from this utility. This will help
> user
> to get GNU archive directly.
And of course, if there's a new release of binutils with a new
improved
version of ar, your utility benefits automatically, without needing to
maintain the code you were going to add separately! :)
cheers,
DaveK
--
Can't think of a witty .sigline today....
[-- Attachment #2: convrenesaslib_utility.patch.tar.gz --]
[-- Type: application/x-gzip, Size: 7380 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] Addition of new option '--rlib' in linker for Renesas SH targets
2006-07-24 7:10 ` Gina Verlekar
@ 2006-08-06 14:34 ` Nick Clifton
0 siblings, 0 replies; 13+ messages in thread
From: Nick Clifton @ 2006-08-06 14:34 UTC (permalink / raw)
To: Gina Verlekar; +Cc: binutils
Hi Gina,
> I have modified the patch as per your comments and suggestions. Please
> find attached herewith the modified patch.
I am sorry but I am still very unhappy with this patch. I think the
whole idea of having the convertrenesaslib program invoking both AR and
OBJCOPY is a bad idea. I really think that you should use a shell
script to do this, and that all that convertrenesaslib should do is
extract the object files from a Renesas format library and write them
into the current directory. The script can take care of the rest - ie
collecting them together again into a GNU format archive, removing the
underscore prefix and deleting the now archived object files. This will
be a much cleaner, simpler way to handle the problem. Plus it follows
the UNIX paradigm of having a set of small simple tools that each
perform one task, but which can be linked together to perform quite
complex operations. Plus it will remove all the command line allocation
and construction hassles that you obviously have in the current code.
Cheers
Nick
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] Addition of new option '--rlib' in linker for Renesas SH targets
2006-07-12 18:08 Nick Clifton
2006-07-13 5:11 ` Gina Verlekar
@ 2006-07-24 7:10 ` Gina Verlekar
2006-08-06 14:34 ` Nick Clifton
1 sibling, 1 reply; 13+ messages in thread
From: Gina Verlekar @ 2006-07-24 7:10 UTC (permalink / raw)
To: Nick Clifton; +Cc: binutils
[-- Attachment #1: Type: text/plain, Size: 4630 bytes --]
Hi Nick,
I have modified the patch as per your comments and suggestions. Please
find
attached herewith the modified patch.
Presently I am facing some problem in adding a test case in binutils for
testing the utility. However, I have attached a separate test case for
convrenesaslib utility along with this mail, for your reference.
I will soon be adding the testcase in binutils also.
>> * The --remove-underscore switch is a bad idea. It would be much
>> cleaner and safer if you just invoke "objcopy
>> --remove-leading-char" for yourself as a separate step after
>> completing the conversion to the GNU ar format.
Whenever a user wants to use custom Renesas library file with a project
compiled
using sh*-linux toolchain, the leading underscores of all functions and
global
symbols in the Renesas library file have to be removed.
If this is not done, the user will get 'undefined references' errors for
all the
functions and global symbols in the library file.
Hence a '--remove-underscore' switch is provided in the convrenesaslib
utility
for ease of use.
Changelog
2006-07-22 Gina G. Verlekar <ginav@kpitcummins.com>
* convrenesaslib.c: Add new file
* Makefile.am: Modify to build convrenesaslib.c.
* configure.in: Check for Renesas SH targets to build
convrenesaslib.
* doc/binutils.texi: Add documentation for convrenesaslib
utility.
Any comments will be appreciated.
Regards,
Gina Verlekar
KPIT Cummins InfoSystems Ltd.
Pune, India
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Free download of GNU based tool-chains for Renesas SH, H8, R8C, M16C and
M32C Series. The following site also offers free technical support to
its
users.
Visit http://www.kpitgnutools.com for details.
Latest versions of KPIT GNU tools were released on June 1, 2006.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-----Original Message-----
From: Nick Clifton [mailto:nickc@redhat.com]
Sent: Wednesday, July 12, 2006 11:39 PM
To: Gina Verlekar
Cc: binutils@sourceware.org
Subject: Re: [PATCH] Addition of new option '--rlib' in linker for
Renesas SH
targets
Hi Gina,
> Please refer to the link below for the patch I had submitted:
> http://sources.redhat.com/ml/binutils/2006-07/msg00068.html
Sorry for the delay in reviewing this patch.
Unfortunately I do not think that it is ready for inclusion into the
sources yet. The problems that I have with it are:
* The changes to Makefile.am mean that recreating Makefile.in
results a warning message about the convrenesaslib_SOURCES being
defined but not used. You need to add it to the EXTRA_PROGRAMS
definition.
* The copyright comment at the start of convrenesaslib.c has the
wrong address for the FSF and it says that the tool is part of GLD
whereas in fact it is part of the GNU Binutils.
* REPORT_BUGS_TO is defined in the bin-bugs.h header.
* Having the "magic_num" field of the rlib_header structure be of
the "unsigned char" type results in compile time warning messages
when it is used as an argument to strcpy().
* None of the textual output of the program has been
internationalized.
* The --remove-underscore switch is a bad idea. It would be much
cleaner and safer if you just invoke "objcopy
--remove-leading-char" for yourself as a separate step after
completing the conversion to the GNU ar format.
* The indentation and formatting do not quite match up to the GNU
Coding Standard.
* The use of the program_name array looks very strange to me. I
think that it would be much cleaner if you left program_name as
being the value of argv[0] and you used a different variable when
you are constructing the ar command line.
* There are various "magic" constants in some of the malloc() calls
(eg + 50, or + 100) without any explanation of where they come
from. There are also several fixed length arrays that should not
be fixed (eg filepath, module_name).
* The fatal() function should be used in place of the
printf();exit(1); combination currently used.
* [optional] Adding a --verbose switch would be useful. It could
tell the user the command line it is using to invoke "ar", and
also mention when files are being created and deleted.
* [optional] A test case to check that the tool works would be very
helpful.
Cheers
Nick
[-- Attachment #2: testcase.tar.gz --]
[-- Type: application/x-gzip, Size: 1818 bytes --]
[-- Attachment #3: patch.tar.gz --]
[-- Type: application/x-gzip, Size: 7555 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] Addition of new option '--rlib' in linker for Renesas SH targets
2006-07-12 18:08 Nick Clifton
@ 2006-07-13 5:11 ` Gina Verlekar
2006-07-24 7:10 ` Gina Verlekar
1 sibling, 0 replies; 13+ messages in thread
From: Gina Verlekar @ 2006-07-13 5:11 UTC (permalink / raw)
To: Nick Clifton; +Cc: binutils
Hi Nick,
Thank you very much for the detailed review.
I will implement all the mentioned changes and re-post the patch.
Regards,
Gina Verlekar
KPIT Cummins InfoSystems Ltd.
Pune, India
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Free download of GNU based tool-chains for Renesas SH, H8, R8C, M16C and
M32C Series.
The following site also offers free technical support to its users.
Visit http://www.kpitgnutools.com for details.
Latest versions of KPIT GNU tools were released on June 1, 2006.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-----Original Message-----
From: Nick Clifton [mailto:nickc@redhat.com]
Sent: Wednesday, July 12, 2006 11:39 PM
To: Gina Verlekar
Cc: binutils@sourceware.org
Subject: Re: [PATCH] Addition of new option '--rlib' in linker for
Renesas SH targets
Hi Gina,
> Please refer to the link below for the patch I had submitted:
> http://sources.redhat.com/ml/binutils/2006-07/msg00068.html
Sorry for the delay in reviewing this patch.
Unfortunately I do not think that it is ready for inclusion into the
sources yet. The problems that I have with it are:
* The changes to Makefile.am mean that recreating Makefile.in
results a warning message about the convrenesaslib_SOURCES being
defined but not used. You need to add it to the EXTRA_PROGRAMS
definition.
* The copyright comment at the start of convrenesaslib.c has the
wrong address for the FSF and it says that the tool is part of GLD
whereas in fact it is part of the GNU Binutils.
* REPORT_BUGS_TO is defined in the bin-bugs.h header.
* Having the "magic_num" field of the rlib_header structure be of
the "unsigned char" type results in compile time warning messages
when it is used as an argument to strcpy().
* None of the textual output of the program has been
internationalized.
* The --remove-underscore switch is a bad idea. It would be much
cleaner and safer if you just invoke "objcopy
--remove-leading-char" for yourself as a separate step after
completing the conversion to the GNU ar format.
* The indentation and formatting do not quite match up to the GNU
Coding Standard.
* The use of the program_name array looks very strange to me. I
think that it would be much cleaner if you left program_name as
being the value of argv[0] and you used a different variable when
you are constructing the ar command line.
* There are various "magic" constants in some of the malloc() calls
(eg + 50, or + 100) without any explanation of where they come
from. There are also several fixed length arrays that should not
be fixed (eg filepath, module_name).
* The fatal() function should be used in place of the
printf();exit(1); combination currently used.
* [optional] Adding a --verbose switch would be useful. It could
tell the user the command line it is using to invoke "ar", and
also mention when files are being created and deleted.
* [optional] A test case to check that the tool works would be very
helpful.
Cheers
Nick
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] Addition of new option '--rlib' in linker for Renesas SH targets
@ 2006-07-12 18:08 Nick Clifton
2006-07-13 5:11 ` Gina Verlekar
2006-07-24 7:10 ` Gina Verlekar
0 siblings, 2 replies; 13+ messages in thread
From: Nick Clifton @ 2006-07-12 18:08 UTC (permalink / raw)
To: GinaV; +Cc: binutils
Hi Gina,
> Please refer to the link below for the patch I had submitted:
> http://sources.redhat.com/ml/binutils/2006-07/msg00068.html
Sorry for the delay in reviewing this patch.
Unfortunately I do not think that it is ready for inclusion into the
sources yet. The problems that I have with it are:
* The changes to Makefile.am mean that recreating Makefile.in
results a warning message about the convrenesaslib_SOURCES being
defined but not used. You need to add it to the EXTRA_PROGRAMS
definition.
* The copyright comment at the start of convrenesaslib.c has the
wrong address for the FSF and it says that the tool is part of GLD
whereas in fact it is part of the GNU Binutils.
* REPORT_BUGS_TO is defined in the bin-bugs.h header.
* Having the "magic_num" field of the rlib_header structure be of
the "unsigned char" type results in compile time warning messages
when it is used as an argument to strcpy().
* None of the textual output of the program has been
internationalized.
* The --remove-underscore switch is a bad idea. It would be much
cleaner and safer if you just invoke "objcopy
--remove-leading-char" for yourself as a separate step after
completing the conversion to the GNU ar format.
* The indentation and formatting do not quite match up to the GNU
Coding Standard.
* The use of the program_name array looks very strange to me. I
think that it would be much cleaner if you left program_name as
being the value of argv[0] and you used a different variable when
you are constructing the ar command line.
* There are various "magic" constants in some of the malloc() calls
(eg + 50, or + 100) without any explanation of where they come
from. There are also several fixed length arrays that should not
be fixed (eg filepath, module_name).
* The fatal() function should be used in place of the
printf();exit(1); combination currently used.
* [optional] Adding a --verbose switch would be useful. It could
tell the user the command line it is using to invoke "ar", and
also mention when files are being created and deleted.
* [optional] A test case to check that the tool works would be very
helpful.
Cheers
Nick
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] Addition of new option '--rlib' in linker for Renesas SH targets
2006-06-28 15:51 ` Pedro Alves
@ 2006-06-29 18:37 ` Dave Korn
0 siblings, 0 replies; 13+ messages in thread
From: Dave Korn @ 2006-06-29 18:37 UTC (permalink / raw)
To: 'Pedro Alves', 'Gina Verlekar'; +Cc: binutils
On 28 June 2006 13:34, Pedro Alves wrote:
> Pedro Alves wrote:
>
>> Gina Verlekar wrote:
>>> The patch attached herewith adds a new option '--rlib' to the linker.
>>> This patch converts the Renesas library file into a GNU archive with name
>>> <filename>.rlib. This file is created in the same directory as the Renesas
>>> library file. This created GNU archive is then passed to the Linker for
>>> further processing. This option can be used multiple times to link
>>> multiple Renesas SH library
>>> files.
>> If the Renesas library is fully converted into a GNU archive, why isn't
>> this implimented as a separate tool? One that converts the libs only once,
>> and be done with it so the user can use -l normally. You could even
>> integrate the tool into the build system, so it would be transparent like
>> your patches aims at being.
> I took a quick look at the patch, and can't see anything that would
> prevent you
> from splitting process_renesas_library_file into a seperate tool.
> As I understand the patch, process_renesas_library_file function
> extracts the object files of the renesas lib,
> and then you then call create_gnu_archive on the files mimicing what ar
> q does.
>
> You could instead have (simplified):
>
> rlibextract $(renesaslib) $(outputdir)
> ar q librenlib.a $(outputdir)/*
> ld $(objects) -lrenlib
>
> rlibextract being your new tool.
>
> It would reduce code duplication,
> you would be able to maintain it with a different release cycle from
> binutils,
> *and* it could be used with older binutils versions.
I agree. Cut-n-paste duplication of a huge chunk of ar.c is a bad idea.
Creating and deleting loads of temp files in your system's cross-libs dir is a
bad idea too; who says the user doing the compile would even have write perms
there?
cheers,
DaveK
--
Can't think of a witty .sigline today....
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] Addition of new option '--rlib' in linker for Renesas SH targets
2006-06-26 17:28 ` Pedro Alves
@ 2006-06-28 15:51 ` Pedro Alves
2006-06-29 18:37 ` Dave Korn
0 siblings, 1 reply; 13+ messages in thread
From: Pedro Alves @ 2006-06-28 15:51 UTC (permalink / raw)
To: Gina Verlekar; +Cc: binutils
Pedro Alves wrote:
> Gina Verlekar wrote:
>
>> Hi,
>>
>> The patch attached herewith adds a new option '--rlib' to the linker.
>> Using this
>> option, Linker links a Renesas SH library file (created by Renesas
>> Compiler)
>> with GNU object files.
>> '--rlib' option is supported only for Renesas SH targets.
>>
>> The format of the option is:
>> --rlib=<filename >
>> where 'filename' is the Renesas SH library file to be linked.
>>
>> This patch converts the Renesas library file into a GNU archive with
>> name
>> <filename>.rlib. This file is created in the same directory as the
>> Renesas
>> library file. This created GNU archive is then passed to the Linker for
>> further
>> processing. This option can be used multiple times to link multiple
>> Renesas SH
>> library
>> files.
>>
>>
>>
> If the Renesas library is fully converted into a GNU archive, why
> isn't this implimented as a
> separate tool? One that converts the libs only once, and be done with
> it so the user can use -l
> normally. You could even integrate the tool into the build system, so
> it would be transparent
> like your patches aims at being.
I took a quick look at the patch, and can't see anything that would
prevent you
from splitting process_renesas_library_file into a seperate tool.
As I understand the patch, process_renesas_library_file function
extracts the object files of the renesas lib,
and then you then call create_gnu_archive on the files mimicing what ar
q does.
You could instead have (simplified):
rlibextract $(renesaslib) $(outputdir)
ar q librenlib.a $(outputdir)/*
ld $(objects) -lrenlib
rlibextract being your new tool.
It would reduce code duplication,
you would be able to maintain it with a different release cycle from
binutils,
*and* it could be used with older binutils versions.
Wouldn't this be better? Or am I missing something?
Cheers,
Pedro Alves
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] Addition of new option '--rlib' in linker for Renesas SH targets
2006-06-26 15:54 ` Andrew STUBBS
@ 2006-06-28 12:33 ` Gina Verlekar
0 siblings, 0 replies; 13+ messages in thread
From: Gina Verlekar @ 2006-06-28 12:33 UTC (permalink / raw)
To: Andrew STUBBS; +Cc: binutils
[-- Attachment #1: Type: text/plain, Size: 1648 bytes --]
Hi Andrew,
>I assume 'rlib' means 'Renesas library'? Would it not be better for the
>option to say that? I though it meant either 'relocatable library' or
>something to do with -rpath or -rlink, when I first saw it.
Thank you for your reply. I agree to your suggestion.
Please find attached modified patch in which option name "--rlib" is
changed to
"--renesas-library".
Regards,
Gina Verlekar
KPIT Cummins InfoSystems Ltd.
Pune, India
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Free download of GNU based tool-chains for Renesas SH, H8, R8C, M16C and
M32C
Series.
The following site also offers free technical support to its users.
Visit http://www.kpitgnutools.com for details.
Latest versions of KPIT GNU tools were released on June 1, 2006.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-----Original Message-----
From: Andrew STUBBS [mailto:andrew.stubbs@st.com]
Sent: Monday, June 26, 2006 9:14 PM
To: Gina Verlekar
Cc: binutils@sourceware.org
Subject: Re: [PATCH] Addition of new option '--rlib' in linker for
Renesas SH targets
Gina Verlekar wrote:
> Hi,
>
> The patch attached herewith adds a new option '--rlib' to the linker.
> Using this
> option, Linker links a Renesas SH library file (created by Renesas
> Compiler)
> with GNU object files.
> '--rlib' option is supported only for Renesas SH targets.
I assume 'rlib' means 'Renesas library'? Would it not be better for the
option to say that? I though it meant either 'relocatable library' or
something to do with -rpath or -rlink, when I first saw it.
Andrew
[-- Attachment #2: renesas-library-option.patch.tar.gz --]
[-- Type: application/x-gzip, Size: 9369 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] Addition of new option '--rlib' in linker for Renesas SH targets
2006-06-26 13:47 Gina Verlekar
2006-06-26 15:54 ` Andrew STUBBS
@ 2006-06-26 17:28 ` Pedro Alves
2006-06-28 15:51 ` Pedro Alves
1 sibling, 1 reply; 13+ messages in thread
From: Pedro Alves @ 2006-06-26 17:28 UTC (permalink / raw)
To: Gina Verlekar; +Cc: binutils
Gina Verlekar wrote:
>Hi,
>
>The patch attached herewith adds a new option '--rlib' to the linker.
>Using this
>option, Linker links a Renesas SH library file (created by Renesas
>Compiler)
>with GNU object files.
>'--rlib' option is supported only for Renesas SH targets.
>
>The format of the option is:
>--rlib=<filename >
>where 'filename' is the Renesas SH library file to be linked.
>
>This patch converts the Renesas library file into a GNU archive with
>name
><filename>.rlib. This file is created in the same directory as the
>Renesas
>library file. This created GNU archive is then passed to the Linker for
>further
>processing.
>This option can be used multiple times to link multiple Renesas SH
>library
>files.
>
>
>
If the Renesas library is fully converted into a GNU archive, why isn't
this implimented as a
separate tool? One that converts the libs only once, and be done with it
so the user can use -l
normally. You could even integrate the tool into the build system, so it
would be transparent
like your patches aims at being.
Cheers,
Pedro Alves
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] Addition of new option '--rlib' in linker for Renesas SH targets
2006-06-26 13:47 Gina Verlekar
@ 2006-06-26 15:54 ` Andrew STUBBS
2006-06-28 12:33 ` Gina Verlekar
2006-06-26 17:28 ` Pedro Alves
1 sibling, 1 reply; 13+ messages in thread
From: Andrew STUBBS @ 2006-06-26 15:54 UTC (permalink / raw)
To: Gina Verlekar; +Cc: binutils
Gina Verlekar wrote:
> Hi,
>
> The patch attached herewith adds a new option '--rlib' to the linker.
> Using this
> option, Linker links a Renesas SH library file (created by Renesas
> Compiler)
> with GNU object files.
> '--rlib' option is supported only for Renesas SH targets.
I assume 'rlib' means 'Renesas library'? Would it not be better for the
option to say that? I though it meant either 'relocatable library' or
something to do with -rpath or -rlink, when I first saw it.
Andrew
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] Addition of new option '--rlib' in linker for Renesas SH targets
@ 2006-06-26 13:47 Gina Verlekar
2006-06-26 15:54 ` Andrew STUBBS
2006-06-26 17:28 ` Pedro Alves
0 siblings, 2 replies; 13+ messages in thread
From: Gina Verlekar @ 2006-06-26 13:47 UTC (permalink / raw)
To: binutils
[-- Attachment #1: Type: text/plain, Size: 1769 bytes --]
Hi,
The patch attached herewith adds a new option '--rlib' to the linker.
Using this
option, Linker links a Renesas SH library file (created by Renesas
Compiler)
with GNU object files.
'--rlib' option is supported only for Renesas SH targets.
The format of the option is:
--rlib=<filename >
where 'filename' is the Renesas SH library file to be linked.
This patch converts the Renesas library file into a GNU archive with
name
<filename>.rlib. This file is created in the same directory as the
Renesas
library file. This created GNU archive is then passed to the Linker for
further
processing.
This option can be used multiple times to link multiple Renesas SH
library
files.
Patch has been generated for latest snapshot of binutils
(binutils-060621).
No new regression failures are found.
Changelog
2006-06-26 Gina G. Verlekar <ginav@kpitcummins.com>
* lexsup.c: Add --rlib option for linking Renesas SH library
file.
* ldrlib.c: Add new file for processing Renesas SH library file.
* Makefile.in: Modify to include ldrlib.c file for compilation.
* Makefile.am: Likewise.
* ld.texinfo: Add documentation for linker option '--rlib'.
* configdoc.texi: Likewise.
Any comments will be appreciated.
Regards,
Gina Verlekar
KPIT Cummins InfoSystems Ltd.
Pune, India
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Free download of GNU based tool-chains for Renesas SH, H8, R8C, M16C and
M32C
Series.
The following site also offers free technical support to its users.
Visit http://www.kpitgnutools.com for details.
Latest versions of KPIT GNU tools were released on June 1, 2006.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[-- Attachment #2: rlib.patch.tar.gz --]
[-- Type: application/x-gzip, Size: 9330 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2006-08-06 14:34 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-07-04 8:21 [PATCH] Addition of new option '--rlib' in linker for Renesas SH targets Gina Verlekar
2006-07-04 11:24 ` Dave Korn
2006-07-07 8:51 ` Gina Verlekar
-- strict thread matches above, loose matches on Subject: below --
2006-07-12 18:08 Nick Clifton
2006-07-13 5:11 ` Gina Verlekar
2006-07-24 7:10 ` Gina Verlekar
2006-08-06 14:34 ` Nick Clifton
2006-06-26 13:47 Gina Verlekar
2006-06-26 15:54 ` Andrew STUBBS
2006-06-28 12:33 ` Gina Verlekar
2006-06-26 17:28 ` Pedro Alves
2006-06-28 15:51 ` Pedro Alves
2006-06-29 18:37 ` Dave Korn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).