From: Nick Clifton <nickc@redhat.com>
To: Alexey Lapshin <alexey.lapshin@espressif.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Cc: Ivan Grokhotkov <ivan@espressif.com>,
Alexey Gerenkov <alexey.gerenkov@espressif.com>,
Anton Maklakov <anton.maklakov@espressif.com>
Subject: Re: [PATCH] bfd: xtensa: fix __stop_SECTION literal drop,
Date: Wed, 5 Oct 2022 12:15:37 +0100 [thread overview]
Message-ID: <1aa71b21-da00-7006-3a3d-1a96e4a181fb@redhat.com> (raw)
In-Reply-To: <c0211bc9c57be6c79c6d878ce147f63b657f461d.camel@espressif.com>
Hi Alexey,
> Literals placement algorithm may drop __stop_SECTION symbol as
> duplicated because it is not initialized yet and we can not differ it
> from __start_SECTION symbol at this stage. Both symbols will be
> initialized a bit later.
> This workaround prevented start_stop symbols from equality in compare
> function
> ---
> bfd/elf32-xtensa.c | 7 +++++++
> ld/testsuite/ld-xtensa/startstop.d | 6 ++++++
> ld/testsuite/ld-xtensa/startstop.s | 16 ++++++++++++++++
> ld/testsuite/ld-xtensa/xtensa.exp | 2 ++
Patch approved - please apply.
Cheers
Nick
next prev parent reply other threads:[~2022-10-05 11:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 16:22 Alexey Lapshin
2022-10-05 11:15 ` Nick Clifton [this message]
2023-05-24 11:38 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aa71b21-da00-7006-3a3d-1a96e4a181fb@redhat.com \
--to=nickc@redhat.com \
--cc=alexey.gerenkov@espressif.com \
--cc=alexey.lapshin@espressif.com \
--cc=anton.maklakov@espressif.com \
--cc=binutils@sourceware.org \
--cc=ivan@espressif.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).