From: Jan Beulich <jbeulich@suse.com>
To: Binutils <binutils@sourceware.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>
Subject: [PATCH 2/6] x86: suppress optimization after potential non-insn
Date: Fri, 24 Nov 2023 10:03:50 +0100 [thread overview]
Message-ID: <1cfe196e-4830-49f2-b06c-9c947c4996b5@suse.com> (raw)
In-Reply-To: <f5b4b6f8-4553-459e-a5ea-35b14055be77@suse.com>
Just like avoiding to do other transformations potentially affected by
stand-alone prefixes or direct data emission, also avoid optimization
on the following insn.
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -5120,6 +5120,11 @@ md_assemble (char *line)
retry:
init_globals ();
+ /* Suppress optimization when the last thing we saw may not have been
+ a proper instruction (e.g. a stand-alone prefix or .byte). */
+ if (last_insn->kind != last_insn_other)
+ i.no_optimize = true;
+
/* First parse an instruction mnemonic & call i386_operand for the operands.
We assume that the scrubber has arranged it so that line[0] is the valid
start of a (possibly prefixed) mnemonic. */
next prev parent reply other threads:[~2023-11-24 9:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 9:02 [PATCH 0/6] correct and further utilize x86'es last-insn tracking Jan Beulich
2023-11-24 9:03 ` [PATCH 1/6] x86: last-insn recording should be per-section Jan Beulich
2023-11-24 9:04 ` [PATCH 3/6] gas: no md_cons_align() for .nop{,s} Jan Beulich
2023-11-24 13:29 ` [PATCH 1/6] x86: last-insn recording should be per-section Jan Beulich
2023-11-24 9:03 ` Jan Beulich [this message]
2023-11-24 9:05 ` [PATCH 4/6] x86: i386_cons_align() badly affects diagnostics Jan Beulich
2023-11-24 9:05 ` [PATCH 5/6] x86: adjust NOP generation after potential non-insn Jan Beulich
2023-11-24 9:06 ` [PATCH 6/6] gas: drop unused fields from struct segment_info_struct Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cfe196e-4830-49f2-b06c-9c947c4996b5@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).