public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Binutils <binutils@sourceware.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>, Nick Clifton <nickc@redhat.com>,
	Alan Modra <amodra@gmail.com>
Subject: [PATCH 6/6] gas: drop unused fields from struct segment_info_struct
Date: Fri, 24 Nov 2023 10:06:18 +0100	[thread overview]
Message-ID: <c3ac7781-313d-4c21-b855-078f994ce6cd@suse.com> (raw)
In-Reply-To: <f5b4b6f8-4553-459e-a5ea-35b14055be77@suse.com>

user_stuff, dot, and lineno_list_{head,tail} have no users (left), while
bfd_section was only ever written.

--- a/gas/subsegs.c
+++ b/gas/subsegs.c
@@ -61,7 +61,6 @@ alloc_seginfo (segT seg)
 
   seginfo = obstack_alloc (&notes, sizeof (*seginfo));
   memset (seginfo, 0, sizeof (*seginfo));
-  seginfo->bfd_section = seg;
   bfd_set_section_userdata (seg, seginfo);
 }
 /*
--- a/gas/subsegs.h
+++ b/gas/subsegs.h
@@ -71,23 +71,13 @@ typedef struct segment_info_struct {
      there are frags.  */
   unsigned int bss : 1;
 
-  int user_stuff;
-
   /* Fixups for this segment.  This is only valid after the frchains
      are run together.  */
   fixS *fix_root;
   fixS *fix_tail;
 
-  symbolS *dot;
-
-  struct lineno_list *lineno_list_head;
-  struct lineno_list *lineno_list_tail;
-
-  /* Which BFD section does this gas segment correspond to?  */
-  asection *bfd_section;
-
   /* NULL, or pointer to the gas symbol that is the section symbol for
-     this section.  sym->bsym and bfd_section->symbol should be the same.  */
+     this section.  */
   symbolS *sym;
 
   /* Used by dwarf2dbg.c for this section's line table entries.  */


      parent reply	other threads:[~2023-11-24  9:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-24  9:02 [PATCH 0/6] correct and further utilize x86'es last-insn tracking Jan Beulich
2023-11-24  9:03 ` [PATCH 1/6] x86: last-insn recording should be per-section Jan Beulich
2023-11-24  9:04   ` [PATCH 3/6] gas: no md_cons_align() for .nop{,s} Jan Beulich
2023-11-24 13:29   ` [PATCH 1/6] x86: last-insn recording should be per-section Jan Beulich
2023-11-24  9:03 ` [PATCH 2/6] x86: suppress optimization after potential non-insn Jan Beulich
2023-11-24  9:05 ` [PATCH 4/6] x86: i386_cons_align() badly affects diagnostics Jan Beulich
2023-11-24  9:05 ` [PATCH 5/6] x86: adjust NOP generation after potential non-insn Jan Beulich
2023-11-24  9:06 ` Jan Beulich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3ac7781-313d-4c21-b855-078f994ce6cd@suse.com \
    --to=jbeulich@suse.com \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=hjl.tools@gmail.com \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).