public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Michael Eager <eager@eagercon.com>
To: Jan Beulich <jbeulich@suse.com>, Neal Frager <neal.frager@amd.com>
Cc: ibai.erkiaga-elorza@amd.com, nagaraju.mekala@amd.com,
	mark.hatle@amd.com, sadanand.mutyala@amd.com,
	appa.rao.nali@amd.com, vidhumouli.hunsigida@amd.com,
	luca.ceresoli@bootlin.com, binutils@sourceware.org
Subject: Re: [PATCH v1 1/1] gas: expr: fix support .long 0U and .long 0u
Date: Thu, 28 Sep 2023 12:27:46 -0700	[thread overview]
Message-ID: <1eb5429b-94dc-e394-14f3-9063f19125eb@eagercon.com> (raw)
In-Reply-To: <424aef37-8ee6-5309-8342-502e0f41b73c@suse.com>

On 9/27/23 06:33, Jan Beulich via Binutils wrote:
> On 27.09.2023 15:21, Neal Frager via Binutils wrote:
>> Fix support for .long 0U and .long 0u in GCC.
>>
>> This patch has been tested for years of AMD Xilinx Yocto
>> releases as part of the following patch set:
>>
>> https://github.com/Xilinx/meta-xilinx/tree/master/meta-microblaze/recipes-devtools/binutils/binutils
>>
>> Signed-off-by: Neal Frager <neal.frager@amd.com>
>> ---
>>   gas/expr.c | 9 +++++++++
>>   1 file changed, 9 insertions(+)
> 
> Without a testcase demonstrating what's wrong, I'd almost be inclined to say
> that ...
> 
>> --- a/gas/expr.c
>> +++ b/gas/expr.c
>> @@ -824,6 +824,15 @@ operand (expressionS *expressionP, enum expr_mode mode)
>>   	      break;
>>   	    }
>>   	}
>> +      if ((*input_line_pointer == 'U') || (*input_line_pointer == 'u'))
>> +	{
>> +	  input_line_pointer--;
>> +
>> +	  integer_constant ((NUMBERS_WITH_SUFFIX || flag_m68k_mri)
>> +	                    ? 0 : 10,
>> +	                    expressionP);
>> +	  break;
>> +	}
>>         c = *input_line_pointer;
>>         switch (c)
>>   	{
> 
> ... this ought to be covered by logic in integer_constant() already. But I
> think I see what the issue is. Nevertheless, go look for tc_allow_U_suffix,
> which wants using here as well. Further I think the same issue then exists
> for L/l suffixes?
> 
> Plus I think you want to add the new code to the switch() statement rather
> than immediately ahead of it.
> 
> Jan
> 

Neal --

Can you provide a test case for this patch?  I'm not able to reproduce 
any error.

Please take a look at gas/expr.c:541-543 (PR 19910: Look for, and 
ignore, a U suffix to the number).  Is this a fix for the same issue?
https://sourceware.org/bugzilla/show_bug.cgi?id=19910

As Jan says, it looks like this code, if needed, should be in the switch 
  statement.


-- 
Michael Eager


  reply	other threads:[~2023-09-28 19:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-27 13:21 Neal Frager
2023-09-27 13:33 ` Jan Beulich
2023-09-28 19:27   ` Michael Eager [this message]
2023-10-01 16:22     ` Frager, Neal
2023-10-01 16:34       ` Michael Eager
2023-10-01 18:06         ` Frager, Neal
2023-10-16  9:18       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1eb5429b-94dc-e394-14f3-9063f19125eb@eagercon.com \
    --to=eager@eagercon.com \
    --cc=appa.rao.nali@amd.com \
    --cc=binutils@sourceware.org \
    --cc=ibai.erkiaga-elorza@amd.com \
    --cc=jbeulich@suse.com \
    --cc=luca.ceresoli@bootlin.com \
    --cc=mark.hatle@amd.com \
    --cc=nagaraju.mekala@amd.com \
    --cc=neal.frager@amd.com \
    --cc=sadanand.mutyala@amd.com \
    --cc=vidhumouli.hunsigida@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).