* [PATCH] aarch64: Treat operand "SME list of ZA tiles" as immediate (PR 31561)
@ 2024-03-27 16:47 Jens Remus
2024-04-09 10:33 ` Nick Clifton
0 siblings, 1 reply; 3+ messages in thread
From: Jens Remus @ 2024-03-27 16:47 UTC (permalink / raw)
To: binutils, Richard Earnshaw, Marcus Shawcroft; +Cc: Jens Remus, Andreas Krebbel
The AArch64 instruction table (aarch64-tbl.h) defines the operand
"SME list of ZA tiles" (SME_list_of_64bit_tiles) as immediate. During
assembly it is correctly encoded as immediate value (imm.value) in
parse_operands. During disassembly it is first correctly decoded as
immediate value (imm.value) in aarch64_ext_imm called by
aarch64_extract_operand, but then erroneously treated as register
number (reg.regno) in aarch64_print_operand.
This resolves the assembler test case "SME extension (ZERO)" to
erroneously fail on s390. On AArch64 - being little-endian - the struct
aarch64_opnd_info union fields reg.regno and imm.value share their
least-significant bits. On s390 - being big-endian - they do not.
opcodes/
PR binutils/31561
* aarch64-opc.c: Treat operand "SME list of ZA tiles" as
immediate.
Bug: https://sourceware.org/PR31561
Signed-off-by: Jens Remus <jremus@linux.ibm.com>
---
opcodes/aarch64-opc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/opcodes/aarch64-opc.c b/opcodes/aarch64-opc.c
index e88c616f4a9f..4a7a6ae784b4 100644
--- a/opcodes/aarch64-opc.c
+++ b/opcodes/aarch64-opc.c
@@ -4236,7 +4236,7 @@ aarch64_print_operand (char *buf, size_t size, bfd_vma pc,
break;
case AARCH64_OPND_SME_list_of_64bit_tiles:
- print_sme_za_list (buf, size, opnd->reg.regno, styler);
+ print_sme_za_list (buf, size, opnd->imm.value, styler);
break;
case AARCH64_OPND_SME_ZA_array_off1x4:
--
2.40.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aarch64: Treat operand "SME list of ZA tiles" as immediate (PR 31561)
2024-03-27 16:47 [PATCH] aarch64: Treat operand "SME list of ZA tiles" as immediate (PR 31561) Jens Remus
@ 2024-04-09 10:33 ` Nick Clifton
2024-04-09 15:23 ` Jens Remus
0 siblings, 1 reply; 3+ messages in thread
From: Nick Clifton @ 2024-04-09 10:33 UTC (permalink / raw)
To: Jens Remus, binutils, Richard Earnshaw, Marcus Shawcroft; +Cc: Andreas Krebbel
Hi Jens,
> opcodes/
> PR binutils/31561
> * aarch64-opc.c: Treat operand "SME list of ZA tiles" as
> immediate.
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aarch64: Treat operand "SME list of ZA tiles" as immediate (PR 31561)
2024-04-09 10:33 ` Nick Clifton
@ 2024-04-09 15:23 ` Jens Remus
0 siblings, 0 replies; 3+ messages in thread
From: Jens Remus @ 2024-04-09 15:23 UTC (permalink / raw)
To: binutils
Cc: Nick Clifton, Andreas Krebbel, Richard Earnshaw, Marcus Shawcroft
Am 09.04.2024 um 12:33 schrieb Nick Clifton:
> Hi Jens,
>
>> opcodes/
>> PR binutils/31561
>> * aarch64-opc.c: Treat operand "SME list of ZA tiles" as
>> immediate.
>
> Approved - please apply.
>
> Cheers
> Nick
>
Thank you! Done.
Regards,
Jens
--
Jens Remus
Linux on Z Development (D3303) and z/VSE Support
+49-7031-16-1128 Office
jremus@de.ibm.com
IBM
IBM Deutschland Research & Development GmbH; Vorsitzender des
Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der
Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-09 15:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-27 16:47 [PATCH] aarch64: Treat operand "SME list of ZA tiles" as immediate (PR 31561) Jens Remus
2024-04-09 10:33 ` Nick Clifton
2024-04-09 15:23 ` Jens Remus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).