From: Daniel Jacobowitz <drow@false.org>
To: Richard Sandiford <rsandifo@redhat.com>
Cc: binutils@sources.redhat.com
Subject: Re: TLS support for MIPS
Date: Tue, 08 Feb 2005 18:04:00 -0000 [thread overview]
Message-ID: <20050208160059.GA9847@nevyn.them.org> (raw)
In-Reply-To: <wvnhdknflg8.fsf@talisman.cambridge.redhat.com>
On Tue, Feb 08, 2005 at 09:30:15AM +0000, Richard Sandiford wrote:
> Daniel Jacobowitz <drow@false.org> writes:
> > OK? Comments, questions, things I failed to explain?
>
> Haven't had chance to read the patch in detail yet, but just in case
> it gets a quick review, I thought I'd beter respond to one thing
> straight away...
>
> I don't like the way you've overloaded the %hi(%other(...)) syntax
> to apply to single relocations. I think it should be reserved for
> true composite relocations (i.e. where the output file has both
> R_MIPS_HI16 and R_MIPS_OTHER entries).
>
> We already have separate operators for things like R_MIPS_CALL_HI16 and
> R_MIPS_CALL_LO16, namely %call_hi() and %call_lo()[*]. I think it'd be
> simpler and more consistent to have %dtpoff_hi() and %dtpoff_lo()
> instead. You'd then be able to get rid of hackery like:
I cribbed this approach from PowerPC (@tprel@ha) because it seemed
eminently sensible. If you'd prefer to use single operators instead,
then I guess I can crib from a different architecture instead.
> > + /* %dtpoff may only be used immediately inside %hi or %lo, with no
> > + other relocations. However, use inside %hi and %lo is valid even
> > + with the old ABI which permits only a single relocation.
> > + Similarly, %tpoff may be used inside %hi and %lo even with the
> > + old ABI, but may also be used on its own. Convert these uses to
> > + a single relocation and give an error for other uses. */
> > + for (i = 0; i < reloc_index; i++)
>
> I really think there should be one operator per relocation.
>
> On the same topic, it would be nice if the %op() names and R_MIPS_THINGY
> names were a bit more consistent. The link between alpha's operator
> names and relocation names is much more obvious, for example.
OK. At this point I think that means renaming the relocations; I just
renamed the operators more sanely recently. Anyone have a preference
on the TPREL vs. TPOFF conventions?
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-02-08 16:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-08 9:30 Daniel Jacobowitz
2005-02-08 13:42 ` Alan Modra
2005-02-21 19:23 ` Daniel Jacobowitz
2005-02-22 9:23 ` Alan Modra
2005-02-08 16:26 ` Richard Sandiford
2005-02-08 18:04 ` Daniel Jacobowitz [this message]
2005-02-09 0:21 ` Eric Christopher
2005-02-09 7:07 ` Thiemo Seufer
2005-02-09 8:17 ` Thiemo Seufer
2005-02-24 21:56 ` Daniel Jacobowitz
2005-03-02 2:07 ` Thiemo Seufer
2005-03-03 10:27 ` Richard Sandiford
2005-03-03 14:28 ` Daniel Jacobowitz
2005-03-03 15:03 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050208160059.GA9847@nevyn.them.org \
--to=drow@false.org \
--cc=binutils@sources.redhat.com \
--cc=rsandifo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).