From: Alan Modra <amodra@bigpond.net.au>
To: binutils@sources.redhat.com
Subject: Re: TLS support for MIPS
Date: Tue, 22 Feb 2005 09:23:00 -0000 [thread overview]
Message-ID: <20050222004434.GD900@bubble.modra.org> (raw)
In-Reply-To: <20050221155214.GA19265@nevyn.them.org>
On Mon, Feb 21, 2005 at 10:52:14AM -0500, Daniel Jacobowitz wrote:
> On Tue, Feb 08, 2005 at 03:46:02PM +1030, Alan Modra wrote:
> > On Mon, Feb 07, 2005 at 06:00:14PM -0500, Daniel Jacobowitz wrote:
> > > * elflink.c: Don't exclude sections based on a shared library input.
> >
> > This would be better in ldlang_add_file, I think.
>
> Like so? Tested on a bunch of different MIPS configurations, with no
> problems. Only thing it might affect is --just-syms with a dynamic
> object... well, don't do that then.
Yes, don't do that. elflink.c:3268
/* ld --just-symbols and dynamic objects don't mix very well.
Test for --just-symbols by looking at info set up by
_bfd_elf_link_just_syms. */
if ((s = abfd->sections) != NULL
&& s->sec_info_type == ELF_INFO_TYPE_JUST_SYMS)
goto error_return;
But of course doing as I suggested means we don't get sec_info_type
set and the error isn't caught. So maybe you'd better do
* ldlang.c (section_already_linked): Don't call
bfd_section_already_linked for dynamic objects.
Patch pre-approved.
--
Alan Modra
IBM OzLabs - Linux Technology Centre
next prev parent reply other threads:[~2005-02-22 0:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-08 9:30 Daniel Jacobowitz
2005-02-08 13:42 ` Alan Modra
2005-02-21 19:23 ` Daniel Jacobowitz
2005-02-22 9:23 ` Alan Modra [this message]
2005-02-08 16:26 ` Richard Sandiford
2005-02-08 18:04 ` Daniel Jacobowitz
2005-02-09 0:21 ` Eric Christopher
2005-02-09 7:07 ` Thiemo Seufer
2005-02-09 8:17 ` Thiemo Seufer
2005-02-24 21:56 ` Daniel Jacobowitz
2005-03-02 2:07 ` Thiemo Seufer
2005-03-03 10:27 ` Richard Sandiford
2005-03-03 14:28 ` Daniel Jacobowitz
2005-03-03 15:03 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050222004434.GD900@bubble.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).