public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* PATCH: Handle record after ZERO terminator
@ 2006-05-15  3:01 H. J. Lu
  2006-05-15 13:37 ` Alan Modra
  0 siblings, 1 reply; 2+ messages in thread
From: H. J. Lu @ 2006-05-15  3:01 UTC (permalink / raw)
  To: binutils

Some .eh_frame section has additional records after ZERO terminator.
This patch prints out them. Also if a CIE pointer is invalid, there
is no need to process further.


H.J.
----
2006-05-13  H.J. Lu  <hongjiu.lu@intel.com>

	* dwarf.c (display_debug_frames): Don't return on ZERO
	terminator.  Skip invalid CIE pointer.

--- binutils/dwarf.c.zero	2006-03-15 19:31:54.000000000 -0800
+++ binutils/dwarf.c	2006-05-11 12:44:32.000000000 -0700
@@ -2927,7 +2927,7 @@ display_debug_frames (struct dwarf_secti
 	{
 	  printf ("\n%08lx ZERO terminator\n\n",
 		    (unsigned long)(saved_start - section_start));
-	  return 1;
+	  continue;
 	}
 
       if (length == 0xffffffff)
@@ -3080,14 +3080,7 @@ display_debug_frames (struct dwarf_secti
 	    {
 	      warn ("Invalid CIE pointer %08lx in FDE at %08lx\n",
 		    cie_id, (unsigned long)(saved_start - section_start));
-	      start = block_end;
-	      fc->ncols = 0;
-	      fc->col_type = xmalloc (sizeof (short int));
-	      fc->col_offset = xmalloc (sizeof (int));
-	      frame_need_space (fc, max_regs - 1);
-	      cie = fc;
-	      fc->augmentation = "";
-	      fc->fde_encoding = 0;
+	      return 1;
 	    }
 	  else
 	    {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PATCH: Handle record after ZERO terminator
  2006-05-15  3:01 PATCH: Handle record after ZERO terminator H. J. Lu
@ 2006-05-15 13:37 ` Alan Modra
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Modra @ 2006-05-15 13:37 UTC (permalink / raw)
  To: H. J. Lu; +Cc: binutils

On Sat, May 13, 2006 at 10:37:20AM -0700, H. J. Lu wrote:
> Some .eh_frame section has additional records after ZERO terminator.
> This patch prints out them.

This part is OK.

> Also if a CIE pointer is invalid, there
> is no need to process further.

This part is not OK.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-05-15  3:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-05-15  3:01 PATCH: Handle record after ZERO terminator H. J. Lu
2006-05-15 13:37 ` Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).