[PATCH] Fix ld-elfweak/size2 for mips

[PATCH] Fix ld-elfweak/size2 for mips

[Thiemo Seufer]

Hello All,

this patch fixes the size2 testcase for mips by adding __start as
an alternative entry symbol. Ok to apply for trunk and branch?


Thiemo


2006-05-16  Thiemo Seufer  <ths@mips.com>

	* ld-elfweak/size2.d, ld-elfweak/size2a.s, ld-elfweak/size2b.s:
	Add __start as entry symbol.


Index: ld/testsuite/ld-elfweak/size2.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-elfweak/size2.d,v
retrieving revision 1.2
diff -u -p -r1.2 size2.d
--- ld/testsuite/ld-elfweak/size2.d	27 Jul 2005 00:08:40 -0000	1.2
+++ ld/testsuite/ld-elfweak/size2.d	16 May 2006 17:40:12 -0000
@@ -4,7 +4,7 @@
 #readelf: -s
 Symbol table '.symtab' contains .* entries:
 #...
-    .*: [0-9a-f]* +1 +FUNC +GLOBAL +DEFAULT +[0-9] +_start
+    .*: [0-9a-f]* +1 +FUNC +GLOBAL +DEFAULT +[0-9] +__?start
 #...
     .*: [0-9a-f]* +1 +FUNC +WEAK +DEFAULT +[0-9] +foo
 #...
Index: ld/testsuite/ld-elfweak/size2a.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-elfweak/size2a.s,v
retrieving revision 1.2
diff -u -p -r1.2 size2a.s
--- ld/testsuite/ld-elfweak/size2a.s	27 Jul 2005 00:08:40 -0000	1.2
+++ ld/testsuite/ld-elfweak/size2a.s	16 May 2006 17:40:12 -0000
@@ -1,9 +1,13 @@
 	.text
 	.global _start
+	.global __start
 	.type _start, "function"
+	.type __start, "function"
 _start:
+__start:
 	.byte 0
 	.size _start, 1
+	.size __start, 1
 
 	.weak foo
 	.type foo, "function"
Index: ld/testsuite/ld-elfweak/size2b.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-elfweak/size2b.s,v
retrieving revision 1.2
diff -u -p -r1.2 size2b.s
--- ld/testsuite/ld-elfweak/size2b.s	27 Jul 2005 00:08:40 -0000	1.2
+++ ld/testsuite/ld-elfweak/size2b.s	16 May 2006 17:40:12 -0000
@@ -1,10 +1,14 @@
 	.text
 	.weak _start
+	.weak __start
 	.type _start, "function"
+	.type __start, "function"
 _start:
+__start:
 	.byte 0
 	.byte 0
 	.size _start, 2
+	.size __start, 2
 
 	.weak foo
 	.type foo, "function"

Re: [PATCH] Fix ld-elfweak/size2 for mips

[Alan Modra]

On Tue, May 16, 2006 at 06:49:22PM +0100, Thiemo Seufer wrote:
> this patch fixes the size2 testcase for mips by adding __start as
> an alternative entry symbol. Ok to apply for trunk and branch?

OK if you have checked that this does not cause a failure on at least
one other architecture besides MIPS.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Re: [PATCH] Fix ld-elfweak/size2 for mips

[Thiemo Seufer]

Alan Modra wrote:
> On Tue, May 16, 2006 at 06:49:22PM +0100, Thiemo Seufer wrote:
> > this patch fixes the size2 testcase for mips by adding __start as
> > an alternative entry symbol. Ok to apply for trunk and branch?
> 
> OK if you have checked that this does not cause a failure on at least
> one other architecture besides MIPS.

Tested on powerpc-linux and committed to trunk.


Thiemo

Re: [PATCH] Fix ld-elfweak/size2 for mips

[Daniel Jacobowitz]

On Wed, May 17, 2006 at 12:31:29PM +0100, Thiemo Seufer wrote:
> Alan Modra wrote:
> > On Tue, May 16, 2006 at 06:49:22PM +0100, Thiemo Seufer wrote:
> > > this patch fixes the size2 testcase for mips by adding __start as
> > > an alternative entry symbol. Ok to apply for trunk and branch?
> > 
> > OK if you have checked that this does not cause a failure on at least
> > one other architecture besides MIPS.
> 
> Tested on powerpc-linux and committed to trunk.

OK for branch too, thanks.

-- 
Daniel Jacobowitz
CodeSourcery