From: Alan Modra <amodra@gmail.com>
To: binutils@sourceware.org
Cc: Eric Christopher <echristo@gmail.com>
Subject: Committing patches for other people
Date: Wed, 19 Feb 2020 22:55:00 -0000 [thread overview]
Message-ID: <20200219225503.GV5570@bubble.grove.modra.org> (raw)
In-Reply-To: <CALehDX4Nz6Z=eBypKLeouDg3RJyc2uPnnnLVeWdj5zqMAN0VCw@mail.gmail.com>
On Wed, Feb 19, 2020 at 01:58:20PM -0800, Eric Christopher wrote:
> I've gone ahead and committed this for Jordan.
OK, but I'll note that when not using "git am" to commit other
people's patches you should take steps to properly attribute
authorship.
git commit --amend --author="Joe Bloe <joe@somewhere.net>"
As it is, "git blame" shows
741cb83912f (Eric Christopher 2020-02-19 13:55:25 -0800
for objdump.c lines changed by Jordan's patch.
None of this matters very much at the moment, but if we are to move
away from ChangeLogs then we will need to learn better habits.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2020-02-19 22:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 20:15 [PATCH] Demangle names when using --line-numbers --disassemble Jordan Rupprecht via binutils
2020-02-19 9:03 ` Alan Modra
2020-02-19 21:58 ` Eric Christopher
2020-02-19 22:55 ` Alan Modra [this message]
2020-02-19 23:35 ` Committing patches for other people Eric Christopher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219225503.GV5570@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=echristo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).