From: Alan Modra <amodra@gmail.com>
To: Hans-Peter Nilsson <hp@bitrange.com>
Cc: binutils@sourceware.org, KONRAD Frederic <frederic.konrad@adacore.com>
Subject: Re: PR24511, nm should not mark symbols in .init_array as "t"
Date: Thu, 27 Feb 2020 07:07:00 -0000 [thread overview]
Message-ID: <20200227070701.GH32593@bubble.grove.modra.org> (raw)
In-Reply-To: <20200227065610.GG32593@bubble.grove.modra.org>
On Thu, Feb 27, 2020 at 05:26:10PM +1030, Alan Modra wrote:
> * syms.c (stt): Trim off all but 'e', 'i' and 'p' entries.
> (coff_section_type): Adjust comment.
> (decode_section_type): Likewise. Call coff_section_type before
> decode_section_type.
> (bfd_decode_symclass): Use 'c' for common sections other than
> the standard one.
With the bfd_decode_symclass change, ld SIZEOF test fails due to
data_end being reported as type '?'.
Does this look a reasonable solution, Hans-Peter?
bfd/
* mmo.c (mmo_scan): Set SEC_DATA for .data.
ld/
* testsuite/ld-mmix/b-fixo2.d: Adjust for .data change.
* testsuite/ld-mmix/sec-2.d: Likewise.
* testsuite/ld-mmix/sec-3.d: Likewise.
* testsuite/ld-mmix/sec-4.d: Likewise.
* testsuite/ld-mmix/spec802.d: Likewise.
* testsuite/ld-mmix/spec803.d: Likewise.
* testsuite/ld-mmix/spec804.d: Likewise.
* testsuite/ld-mmix/spec805.d: Likewise.
* testsuite/ld-mmix/spec806.d: Likewise.
* testsuite/ld-mmix/spec807.d: Likewise.
* testsuite/ld-mmix/spec808.d: Likewise.
diff --git a/bfd/mmo.c b/bfd/mmo.c
index 9ac689d042..073c37c0ac 100644
--- a/bfd/mmo.c
+++ b/bfd/mmo.c
@@ -2074,7 +2074,7 @@ mmo_scan (bfd *abfd)
if (sec != NULL
&& (bfd_section_flags (sec) & SEC_HAS_CONTENTS)
&& !bfd_set_section_flags (sec, (bfd_section_flags (sec)
- | SEC_ALLOC | SEC_LOAD)))
+ | SEC_ALLOC | SEC_LOAD | SEC_DATA)))
error = TRUE;
/* Free whatever resources we took. */
diff --git a/ld/testsuite/ld-mmix/b-fixo2.d b/ld/testsuite/ld-mmix/b-fixo2.d
index e8e2ff845f..3db01eb32d 100644
--- a/ld/testsuite/ld-mmix/b-fixo2.d
+++ b/ld/testsuite/ld-mmix/b-fixo2.d
@@ -16,7 +16,7 @@ Idx Name Size VMA LMA File off Algn
0 \.text 0+8 0+ 0+ 0+ 2\*\*2
CONTENTS, ALLOC, LOAD, CODE
1 \.data 0+4 2068098510aa5564 2068098510aa5564 0+ 2\*\*2
- CONTENTS, ALLOC, LOAD
+ CONTENTS, ALLOC, LOAD, DATA
SYMBOL TABLE:
0+4 g \.text Main
0+4 g \.text a
diff --git a/ld/testsuite/ld-mmix/sec-2.d b/ld/testsuite/ld-mmix/sec-2.d
index 10623f354c..10a9a521ac 100644
--- a/ld/testsuite/ld-mmix/sec-2.d
+++ b/ld/testsuite/ld-mmix/sec-2.d
@@ -13,7 +13,7 @@ Idx Name Size VMA LMA File off Algn
1 \.other 0+50 1000000000000000 1000000000000000 0+ 2\*\*2
CONTENTS, ALLOC, LOAD, CODE, DATA
2 \.data 0+4 2000000000000004 2000000000000004 0+ 2\*\*2
- CONTENTS, ALLOC, LOAD
+ CONTENTS, ALLOC, LOAD, DATA
Contents of section \.text:
0100 e3fd0001 .*
Contents of section \.other:
diff --git a/ld/testsuite/ld-mmix/sec-3.d b/ld/testsuite/ld-mmix/sec-3.d
index 290052b99e..8074e834e1 100644
--- a/ld/testsuite/ld-mmix/sec-3.d
+++ b/ld/testsuite/ld-mmix/sec-3.d
@@ -15,7 +15,7 @@ Idx Name Size VMA LMA File off Algn
2 \.a\.fourth\.section 0+10 0+20 0+20 0+ 2\*\*2
CONTENTS, ALLOC, LOAD, READONLY, DATA
3 \.data 0+4 2000000000000004 2000000000000004 0+ 2\*\*2
- CONTENTS, ALLOC, LOAD
+ CONTENTS, ALLOC, LOAD, DATA
4 anothersec 0+13 2000000000000008 2000000000000008 0+ 2\*\*2
CONTENTS, ALLOC, LOAD, DATA
5 thirdsec 0+a 0+ 0+ 0+ 2\*\*2
diff --git a/ld/testsuite/ld-mmix/sec-4.d b/ld/testsuite/ld-mmix/sec-4.d
index 251f6a28d0..16b65896a7 100644
--- a/ld/testsuite/ld-mmix/sec-4.d
+++ b/ld/testsuite/ld-mmix/sec-4.d
@@ -11,7 +11,7 @@ Idx Name Size VMA LMA File off Algn
0 \.text 0+4 0+100 0+100 0+ 2\*\*2
CONTENTS, ALLOC, LOAD, CODE
1 \.data 0+4 2000000000000004 2000000000000004 0+ 2\*\*2
- CONTENTS, ALLOC, LOAD
+ CONTENTS, ALLOC, LOAD, DATA
2 \.other 0+c 1000000000000000 1000000000000000 0+ 2\*\*2
CONTENTS, ALLOC, LOAD, READONLY, CODE
Contents of section \.text:
diff --git a/ld/testsuite/ld-mmix/spec802.d b/ld/testsuite/ld-mmix/spec802.d
index ea0ebc3d65..cea7de2ee5 100644
--- a/ld/testsuite/ld-mmix/spec802.d
+++ b/ld/testsuite/ld-mmix/spec802.d
@@ -13,7 +13,7 @@ Idx Name Size VMA LMA File off Algn
0 \.text 0+4 0+ 0+ 0+ 2\*\*2
CONTENTS, ALLOC, LOAD, CODE
1 \.data 0+4 2000000000000000 2000000000000000 0+ 2\*\*2
- CONTENTS, ALLOC, LOAD
+ CONTENTS, ALLOC, LOAD, DATA
2 \.MMIX\.spec_data\.80 0+4 0+ 0+ 0+ 2\*\*2
CONTENTS
Contents of section \.text:
diff --git a/ld/testsuite/ld-mmix/spec803.d b/ld/testsuite/ld-mmix/spec803.d
index b933d6ca7d..cc63844425 100644
--- a/ld/testsuite/ld-mmix/spec803.d
+++ b/ld/testsuite/ld-mmix/spec803.d
@@ -13,7 +13,7 @@ Idx Name Size VMA LMA File off Algn
0 \.text 0+4 0+ 0+ 0+ 2\*\*2
CONTENTS, ALLOC, LOAD, CODE
1 \.data 0+4 2000000000000000 2000000000000000 0+ 2\*\*2
- CONTENTS, ALLOC, LOAD
+ CONTENTS, ALLOC, LOAD, DATA
2 \.MMIX\.spec_data\.80 0+c 0+ 0+ 0+ 2\*\*2
CONTENTS
Contents of section \.text:
diff --git a/ld/testsuite/ld-mmix/spec804.d b/ld/testsuite/ld-mmix/spec804.d
index 170bc5e0bd..fd8f0bf376 100644
--- a/ld/testsuite/ld-mmix/spec804.d
+++ b/ld/testsuite/ld-mmix/spec804.d
@@ -13,7 +13,7 @@ Idx Name Size VMA LMA File off Algn
0 \.text 0+4 0+ 0+ 0+ 2\*\*2
CONTENTS, ALLOC, LOAD, CODE
1 \.data 0+4 2000000000000000 2000000000000000 0+ 2\*\*2
- CONTENTS, ALLOC, LOAD
+ CONTENTS, ALLOC, LOAD, DATA
2 \.MMIX\.spec_data\.80 0+10 0+ 0+ 0+ 2\*\*2
CONTENTS
Contents of section \.text:
diff --git a/ld/testsuite/ld-mmix/spec805.d b/ld/testsuite/ld-mmix/spec805.d
index c4cdd02f23..d0562eb138 100644
--- a/ld/testsuite/ld-mmix/spec805.d
+++ b/ld/testsuite/ld-mmix/spec805.d
@@ -13,7 +13,7 @@ Idx Name Size VMA LMA File off Algn
0 \.text 0+4 0+ 0+ 0+ 2\*\*2
CONTENTS, ALLOC, LOAD, CODE
1 \.data 0+4 2000000000000000 2000000000000000 0+ 2\*\*2
- CONTENTS, ALLOC, LOAD
+ CONTENTS, ALLOC, LOAD, DATA
2 \.MMIX\.spec_data\.80 0+14 0+ 0+ 0+ 2\*\*2
CONTENTS
Contents of section \.text:
diff --git a/ld/testsuite/ld-mmix/spec806.d b/ld/testsuite/ld-mmix/spec806.d
index 7f64948971..64d8bf9cf6 100644
--- a/ld/testsuite/ld-mmix/spec806.d
+++ b/ld/testsuite/ld-mmix/spec806.d
@@ -13,7 +13,7 @@ Idx Name Size VMA LMA File off Algn
0 \.text 0+4 0+ 0+ 0+ 2\*\*2
CONTENTS, ALLOC, LOAD, CODE
1 \.data 0+4 2000000000000000 2000000000000000 0+ 2\*\*2
- CONTENTS, ALLOC, LOAD
+ CONTENTS, ALLOC, LOAD, DATA
2 \.MMIX\.spec_data\.80 0+18 0+ 0+ 0+ 2\*\*2
CONTENTS
Contents of section \.text:
diff --git a/ld/testsuite/ld-mmix/spec807.d b/ld/testsuite/ld-mmix/spec807.d
index f37e57a4d5..ef2edb93d3 100644
--- a/ld/testsuite/ld-mmix/spec807.d
+++ b/ld/testsuite/ld-mmix/spec807.d
@@ -13,7 +13,7 @@ Idx Name Size VMA LMA File off Algn
0 \.text 0+4 0+ 0+ 0+ 2\*\*2
CONTENTS, ALLOC, LOAD, CODE
1 \.data 0+4 2000000000000000 2000000000000000 0+ 2\*\*2
- CONTENTS, ALLOC, LOAD
+ CONTENTS, ALLOC, LOAD, DATA
2 \.MMIX\.spec_data\.80 0+1c 0+ 0+ 0+ 2\*\*2
CONTENTS
Contents of section \.text:
diff --git a/ld/testsuite/ld-mmix/spec808.d b/ld/testsuite/ld-mmix/spec808.d
index e1d678485e..00a5347f99 100644
--- a/ld/testsuite/ld-mmix/spec808.d
+++ b/ld/testsuite/ld-mmix/spec808.d
@@ -13,7 +13,7 @@ Idx Name Size VMA LMA File off Algn
0 \.text 0+4 0+ 0+ 0+ 2\*\*2
CONTENTS, ALLOC, LOAD, CODE
1 \.data 0+4 2000000000000000 2000000000000000 0+ 2\*\*2
- CONTENTS, ALLOC, LOAD
+ CONTENTS, ALLOC, LOAD, DATA
2 \.MMIX\.spec_data\.80 0+20 0+ 0+ 0+ 2\*\*2
CONTENTS
Contents of section \.text:
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2020-02-27 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 7:57 Alan Modra
2020-02-26 17:09 ` KONRAD Frederic
2020-02-27 6:56 ` Alan Modra
2020-02-27 7:07 ` Alan Modra [this message]
2020-02-27 17:28 ` Hans-Peter Nilsson
2020-02-27 15:03 ` KONRAD Frederic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227070701.GH32593@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=frederic.konrad@adacore.com \
--cc=hp@bitrange.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).