From: Hans-Peter Nilsson <hp@bitrange.com>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org, KONRAD Frederic <frederic.konrad@adacore.com>
Subject: Re: PR24511, nm should not mark symbols in .init_array as "t"
Date: Thu, 27 Feb 2020 17:28:00 -0000 [thread overview]
Message-ID: <alpine.BSF.2.20.16.2002271226000.57250@arjuna.pair.com> (raw)
In-Reply-To: <20200227070701.GH32593@bubble.grove.modra.org>
On Thu, 27 Feb 2020, Alan Modra wrote:
> On Thu, Feb 27, 2020 at 05:26:10PM +1030, Alan Modra wrote:
> > * syms.c (stt): Trim off all but 'e', 'i' and 'p' entries.
> > (coff_section_type): Adjust comment.
> > (decode_section_type): Likewise. Call coff_section_type before
> > decode_section_type.
> > (bfd_decode_symclass): Use 'c' for common sections other than
> > the standard one.
>
> With the bfd_decode_symclass change, ld SIZEOF test fails due to
> data_end being reported as type '?'.
>
> Does this look a reasonable solution, Hans-Peter?
>
> bfd/
> * mmo.c (mmo_scan): Set SEC_DATA for .data.
> ld/
> * testsuite/ld-mmix/b-fixo2.d: Adjust for .data change.
> * testsuite/ld-mmix/sec-2.d: Likewise.
> * testsuite/ld-mmix/sec-3.d: Likewise.
> * testsuite/ld-mmix/sec-4.d: Likewise.
> * testsuite/ld-mmix/spec802.d: Likewise.
> * testsuite/ld-mmix/spec803.d: Likewise.
> * testsuite/ld-mmix/spec804.d: Likewise.
> * testsuite/ld-mmix/spec805.d: Likewise.
> * testsuite/ld-mmix/spec806.d: Likewise.
> * testsuite/ld-mmix/spec807.d: Likewise.
> * testsuite/ld-mmix/spec808.d: Likewise.
Correcting data sections to be classified as DATA?
Certainly LGTM! :) Thanks.
brgds, H-P
next prev parent reply other threads:[~2020-02-27 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 7:57 Alan Modra
2020-02-26 17:09 ` KONRAD Frederic
2020-02-27 6:56 ` Alan Modra
2020-02-27 7:07 ` Alan Modra
2020-02-27 17:28 ` Hans-Peter Nilsson [this message]
2020-02-27 15:03 ` KONRAD Frederic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSF.2.20.16.2002271226000.57250@arjuna.pair.com \
--to=hp@bitrange.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=frederic.konrad@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).