From: "H.J. Lu" <hjl.tools@gmail.com>
To: binutils@sourceware.org
Subject: [PATCH] elf: Don't set VER_FLG_WEAK
Date: Tue, 25 Jan 2022 16:19:53 -0800 [thread overview]
Message-ID: <20220126001953.652545-1-hjl.tools@gmail.com> (raw)
On Solaris, VER_FLG_WEAK indicates a weak version definition with no
symbols associated with it. It is used to verify the existence of a
particular implementation without any symbol references to the weak
version. Don't set VER_FLG_WEAK since it is unused in binutils.
PR ld/28814
* elflink.c (bfd_elf_size_dynamic_sections): Don't set
VER_FLG_WEAK.
---
bfd/elflink.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/bfd/elflink.c b/bfd/elflink.c
index 2677561478d..ffb4506958f 100644
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -6921,10 +6921,6 @@ bfd_elf_size_dynamic_sections (bfd *output_bfd,
def.vd_version = VER_DEF_CURRENT;
def.vd_flags = 0;
- if (t->globals.list == NULL
- && t->locals.list == NULL
- && ! t->used)
- def.vd_flags |= VER_FLG_WEAK;
def.vd_ndx = t->vernum + (info->create_default_symver ? 2 : 1);
def.vd_cnt = cdeps + 1;
def.vd_hash = bfd_elf_hash (t->name);
--
2.34.1
next reply other threads:[~2022-01-26 0:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 0:19 H.J. Lu [this message]
2022-01-26 3:07 ` Alan Modra
2022-01-26 13:26 ` H.J. Lu
2022-01-31 16:47 ` Florian Weimer
2022-01-31 18:19 ` H.J. Lu
2022-02-01 8:44 Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126001953.652545-1-hjl.tools@gmail.com \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).