From: Andrew Burgess <aburgess@redhat.com>
To: binutils@sourceware.org
Subject: Re: [PATCHv3 0/3] Add Type.is_scalar and Type.is_signed properties
Date: Fri, 25 Feb 2022 13:54:59 +0000 [thread overview]
Message-ID: <20220225135459.GA124242@redhat.com> (raw)
In-Reply-To: <cover.1645788436.git.aburgess@redhat.com>
Apologies, this was sent to the wrong list.
Sorry for the noise.
Andrew
* Andrew Burgess via Binutils <binutils@sourceware.org> [2022-02-25 11:31:09 +0000]:
> Thanks for all the feedback on V1, and V2. Additionally, Simon gave
> some awesome suggestions on IRC
>
> The new V3 series is a complete rewrite, main points are:
>
> - New Type.is_scalar property in patch #1,
>
> - Now have a Type.is_signed property (patch #2), which is either
> True or False. Attempting to read this property on a non-scalar
> type will raise a ValueError.
>
> - Finally, patch #3 adds a test for to cover the 'char' is different
> to 'signed char' and 'unsigned char' issue. This characteristic
> should be detected by simply comparing types.
>
> Thoughts?
>
> Thanks,
> Andrew
>
> ---
>
> Andrew Burgess (3):
> gdb/python: add Type.is_scalar property
> gdb/python: add Type.is_signed property
> gdb/testsuite: add new test for comparing char types in Python
>
> gdb/NEWS | 8 +++
> gdb/doc/python.texi | 16 +++++
> gdb/python/py-type.c | 38 ++++++++++++
> gdb/testsuite/gdb.python/py-arch.exp | 15 ++++-
> gdb/testsuite/gdb.python/py-type.c | 16 +++++
> gdb/testsuite/gdb.python/py-type.exp | 88 +++++++++++++++++++++++++++-
> 6 files changed, 179 insertions(+), 2 deletions(-)
>
> --
> 2.25.4
>
prev parent reply other threads:[~2022-02-25 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1638799543.git.aburgess@redhat.com>
2022-02-25 11:31 ` Andrew Burgess
2022-02-25 11:31 ` [PATCHv3 1/3] gdb/python: add Type.is_scalar property Andrew Burgess
2022-02-25 11:31 ` [PATCHv3 2/3] gdb/python: add Type.is_signed property Andrew Burgess
2022-02-25 11:31 ` [PATCHv3 3/3] gdb/testsuite: add new test for comparing char types in Python Andrew Burgess
2022-02-25 13:54 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220225135459.GA124242@redhat.com \
--to=aburgess@redhat.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).