From: Fangrui Song <i@maskray.me>
To: Alan Modra <amodra@gmail.com>
Cc: Luis Machado <luis.machado@arm.com>, binutils@sourceware.org
Subject: Re: [PATCH, v2] [AArch64] Support AArch64 MTE memory tag dumps in core files
Date: Sat, 23 Apr 2022 14:50:37 -0700 [thread overview]
Message-ID: <20220423215037.xopkysk3ugbkbqkm@gmail.com> (raw)
In-Reply-To: <YmNFGvgHpPBggQOE@squeak.grove.modra.org>
On 2022-04-23, Alan Modra via Binutils wrote:
>On Thu, Apr 21, 2022 at 04:18:41PM +0100, Luis Machado wrote:
>> v2:
>>
>> - Drop arch-specific fields from the generic section data structure.
>> - Use the rawsize field of the section structure to store the original
>> memory range of the memory-tagged area.
>> - Implement the bfd_elf_modify_headers for aarch64, to adjust the values
>> for the memory tag segment according to the Linux Kernel's format.
>
>This looks OK to me, except for defining PT_ARM_MEMTAG_MTE in
>elf/common.h. That belongs in elf/aarch64.h. BTW, why isn't the
>header called PT_AARCH64_MEMTAG_MTE? Using PT_ARM_ looks odd,
>considering that we already have PT_ARM_EXIDX at LOPROC+1.
Agree PT_LOPROC+1 is strange.
next prev parent reply other threads:[~2022-04-23 21:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 14:04 Luis Machado
2022-04-01 1:34 ` Alan Modra
2022-04-01 8:21 ` Luis Machado
2022-04-03 12:04 ` Move microblaze relax info to target specific data Alan Modra
2022-04-21 15:18 ` [PATCH, v2] [AArch64] Support AArch64 MTE memory tag dumps in core files Luis Machado
2022-04-23 0:15 ` Alan Modra
2022-04-23 21:50 ` Fangrui Song [this message]
2022-05-03 11:23 ` Luis Machado
2022-05-03 11:33 ` [PATCH] " Luis Machado
2022-05-11 15:13 ` Luis Machado
2022-05-12 0:18 ` Alan Modra
2022-06-02 3:26 ` Fangrui Song
[not found] ` <DS7PR12MB57657DCC1DA5A6A4ABD7F813CBDE9@DS7PR12MB5765.namprd12.prod.outlook.com>
2022-06-06 7:05 ` Luis Machado
2022-07-19 14:27 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220423215037.xopkysk3ugbkbqkm@gmail.com \
--to=i@maskray.me \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=luis.machado@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).