Re: [PATCH 2/2] partial revert 5a91f93b983184c64b3a9332f5f4339d17941d76

[Huang Pei <huangpei@loongson.cn>]

On Fri, May 13, 2022 at 09:55:23AM +0800, WANG Xuerui wrote:
Hi, 

Resend them with another thread, since the subject changed
> Hi,
> 
> On 5/13/22 09:35, Huang Pei wrote:
> > set elf_backend_default_execstack=0 on loongarch
> 
> Please provide reasons for the change; while I and other people familiar
> with those lower-level details can somehow guess it's because contemporary
> architectures really prefer non-executable stacks by default, for enhancing
> security, it's better to be explicit.
> 
> Plus, please format the subject lines of both your patches, so they conform
> to the repo's conventions. I think they should look like "LoongArch: Do foo"
> or "bfd: LoongArch: Do foo", looking at a few recent commits on various
> components.
> 
> > ---
> >   bfd/elfnn-loongarch.c       | 1 +
> >   ld/testsuite/ld-elf/elf.exp | 1 +
> >   2 files changed, 2 insertions(+)
> > 
> > diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
> > index e4cd9fa107e..94c8e8269d3 100644
> > --- a/bfd/elfnn-loongarch.c
> > +++ b/bfd/elfnn-loongarch.c
> > @@ -130,6 +130,7 @@ struct loongarch_elf_link_hash_table
> >   #define elf_backend_got_header_size (GOT_ENTRY_SIZE * 1)
> >   #define elf_backend_want_dynrelro 1
> > +#define elf_backend_default_execstack 0
> >   /* Generate a PLT header.  */
> > diff --git a/ld/testsuite/ld-elf/elf.exp b/ld/testsuite/ld-elf/elf.exp
> > index ebb5ba090bf..e33a0d08831 100644
> > --- a/ld/testsuite/ld-elf/elf.exp
> > +++ b/ld/testsuite/ld-elf/elf.exp
> > @@ -186,6 +186,7 @@ proc target_defaults_to_execstack {} {
> >   	|| [istarget "*-*-nacl"]
> >   	|| [istarget "arc*-*-*"]
> >   	|| [istarget "ia64*-*-*"]
> > +	|| [istarget "loongarch*-*-*"]
> >   	|| [istarget "nios2*-*-*"]
> >   	|| [istarget "powerpc64*-*-*"]
> >   	|| [istarget "riscv*-*-*"]