* [committed] RISC-V: Fix build failures for -Werror=sign-compare.
@ 2022-10-27 8:48 Nelson Chu
0 siblings, 0 replies; only message in thread
From: Nelson Chu @ 2022-10-27 8:48 UTC (permalink / raw)
To: binutils; +Cc: nelson
elfnn-riscv.c: In function ‘riscv_relax_resolve_delete_relocs’:
elfnn-riscv.c:4256:30: error: operand of ‘?:’ changes signedness from ‘int’ to ‘unsigned int’ due to unsignedness of other operand [-Werror=sign-compare]
So make the operands unsigned could resolve problem.
bfd/
* elfnn-riscv.c (riscv_relax_resolve_delete_relocs): Fixed build
failures for -Werror=sign-compare.
---
bfd/elfnn-riscv.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/bfd/elfnn-riscv.c b/bfd/elfnn-riscv.c
index cf852636c9c..0570a971b5a 100644
--- a/bfd/elfnn-riscv.c
+++ b/bfd/elfnn-riscv.c
@@ -4239,7 +4239,10 @@ riscv_relax_resolve_delete_relocs (bfd *abfd,
rel_next = relocs + i;
if (ELFNN_R_TYPE ((rel_next)->r_info) == R_RISCV_DELETE
&& (rel_next)->r_offset > rel->r_offset)
- break;
+ {
+ BFD_ASSERT (rel_next - rel > 0);
+ break;
+ }
else
rel_next = NULL;
}
@@ -4253,7 +4256,8 @@ riscv_relax_resolve_delete_relocs (bfd *abfd,
rel->r_info = ELFNN_R_INFO (0, R_RISCV_NONE);
/* Skip ahead to the next delete reloc. */
- i = rel_next != NULL ? rel_next - relocs - 1 : sec->reloc_count;
+ i = rel_next != NULL ? (unsigned int) (rel_next - relocs - 1)
+ : sec->reloc_count;
}
return true;
--
2.37.0 (Apple Git-136)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-27 8:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-27 8:48 [committed] RISC-V: Fix build failures for -Werror=sign-compare Nelson Chu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).