public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Fangrui Song <i@maskray.me>
To: "Martin Liška" <mliska@suse.cz>
Cc: Jan Beulich <jbeulich@suse.com>, binutils@sourceware.org
Subject: Re: [PATCH V3] testsuite: support mold linker
Date: Tue, 6 Dec 2022 16:42:43 -0800	[thread overview]
Message-ID: <20221207004243.epcu6lykpdcapc7i@gmail.com> (raw)
In-Reply-To: <20221207003638.46fnrj32r56i2ynl@gmail.com>


On 2022-12-06, Fangrui Song wrote:
>On 2022-12-05, Jan Beulich via Binutils wrote:
>>On 05.12.2022 15:41, Martin Liška wrote:
>>>Mold linker demotes symbols like main to be local and the patch
>>>adjusts expected output from nm.
>>>
>>>Moreover, simplify the regex patterns.
>>
>>Okay.
>>
>>Jan
>>
>
>Not okai to me.  mold seems to wrongly make `main` STB_LOCAL while it
>has default visibility which should stay STB_GLOBAL.

Filed https://github.com/rui314/mold/issues/906

  reply	other threads:[~2022-12-07  0:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-05 12:10 [PATCH] " Martin Liška
2022-12-05 12:22 ` Jan Beulich
2022-12-05 13:46   ` Martin Liška
2022-12-05 13:48     ` [PATCH V2] " Martin Liška
2022-12-05 14:08       ` Jan Beulich
2022-12-05 14:24         ` Martin Liška
2022-12-05 14:48           ` Jan Beulich
2022-12-05 14:52             ` Martin Liška
2022-12-05 15:13               ` Jan Beulich
2022-12-05 14:25         ` Jakub Jelinek
2022-12-05 14:41           ` [PATCH V3] " Martin Liška
2022-12-05 14:50             ` Jan Beulich
2022-12-07  0:36               ` Fangrui Song
2022-12-07  0:42                 ` Fangrui Song [this message]
2022-12-07 13:01                 ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221207004243.epcu6lykpdcapc7i@gmail.com \
    --to=i@maskray.me \
    --cc=binutils@sourceware.org \
    --cc=jbeulich@suse.com \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).