From: Jan Beulich <jbeulich@suse.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: binutils@sourceware.org, Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH V2] testsuite: support mold linker
Date: Mon, 5 Dec 2022 16:13:21 +0100 [thread overview]
Message-ID: <c0bb480e-3fa6-7fee-462d-4131a947e309@suse.com> (raw)
In-Reply-To: <3897a1ce-4ae1-9259-f55b-56afd19d741b@suse.cz>
On 05.12.2022 15:52, Martin Liška wrote:
> On 12/5/22 15:48, Jan Beulich wrote:
>> On 05.12.2022 15:24, Martin Liška wrote:
>>> On 12/5/22 15:08, Jan Beulich wrote:
>>>> On 05.12.2022 14:48, Martin Liška wrote:
>>>> Furthermore I now even less understand ...
>>>>
>>>>> --- a/libbacktrace/Makefile.am
>>>>> +++ b/libbacktrace/Makefile.am
>>>>> @@ -498,7 +498,7 @@ TESTS += mtest_minidebug
>>>>>
>>>>> %_minidebug: %
>>>>> $(NM) -D $< -P --defined-only | $(AWK) '{ print $$1 }' | sort > $<.dsyms
>>>>> - $(NM) $< -P --defined-only | $(AWK) '{ if ($$2 == "T" || $$2 == "t" || $$2 == "D") print $$1 }' | sort > $<.fsyms
>>>>> + $(NM) $< -P --defined-only | $(AWK) '{ if ($$2 == "T" || $$2 == "t" || $$2 == "D" || $$2 == "d") print $$1 }' | sort > $<.fsyms
>>>>
>>>> ... this part of the change, where - as in v1 - you add a check for
>>>> 'd', while a check for 't' (which supposedly is what you're after)
>>>> was already there.
>>>
>>> This nm invocation is supposed to save dynamic symbols (.dyns) and normal symbols ('.fsyms'),
>>> where .fsymc contains both data and functions.
>>>
>>> The symbol which I need to properly list is:
>>>
>>> mtest.c:int global = 1;
>>>
>>> which gets 'b' with mold linker.
>>
>> Yet then 'b' != 'd',
>
> Sure, 'd' should be there.
>
>> and this is unrelated to "main" (which is the only
>> thing you mention in the description)?
>
> I mentioned 'symbols like main', so would it be better mentioning
> 'global symbols and variables'?
Well, apologies - I didn't properly read that sentence, ignoring in
particular the "like". But of course your alternative text sounds
overall better to me ...
Jan
next prev parent reply other threads:[~2022-12-05 15:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 12:10 [PATCH] " Martin Liška
2022-12-05 12:22 ` Jan Beulich
2022-12-05 13:46 ` Martin Liška
2022-12-05 13:48 ` [PATCH V2] " Martin Liška
2022-12-05 14:08 ` Jan Beulich
2022-12-05 14:24 ` Martin Liška
2022-12-05 14:48 ` Jan Beulich
2022-12-05 14:52 ` Martin Liška
2022-12-05 15:13 ` Jan Beulich [this message]
2022-12-05 14:25 ` Jakub Jelinek
2022-12-05 14:41 ` [PATCH V3] " Martin Liška
2022-12-05 14:50 ` Jan Beulich
2022-12-07 0:36 ` Fangrui Song
2022-12-07 0:42 ` Fangrui Song
2022-12-07 13:01 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0bb480e-3fa6-7fee-462d-4131a947e309@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=jakub@redhat.com \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).