From: Indu Bhagat <indu.bhagat@oracle.com>
To: binutils@sourceware.org
Cc: Indu Bhagat <indu.bhagat@oracle.com>
Subject: [PATCH] libsframe: replace an strncat with strcat
Date: Tue, 10 Jan 2023 10:27:45 -0800 [thread overview]
Message-ID: <20230110182745.3641128-1-indu.bhagat@oracle.com> (raw)
Hello,
I noticed the following warning on s390x builds, which drew my attention to the
code in dump_sframe_func_with_fres:
../../binutils-gdb/libsframe/sframe-dump.c:180:7: warning: ‘strncat’ output
truncated before terminating nul copying 3 bytes from a string of the same
length [-Wstringop-truncation]
I think using strcat is just as fine here.
Thanks,
Indu
----------------------------------
Calling strncat with the size of the src string is not so meaningful.
The length argument to strncat should specify the remaining bytes
bytes in the destination; although in this case, it appears to be
unncessary altogether to use strncat in the first place.
libsframe/
* sframe-dump.c (dump_sframe_func_with_fres): Use of strcat is
just as fine.
---
libsframe/sframe-dump.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libsframe/sframe-dump.c b/libsframe/sframe-dump.c
index 320555a0a51..5417a16f48c 100644
--- a/libsframe/sframe-dump.c
+++ b/libsframe/sframe-dump.c
@@ -176,8 +176,7 @@ dump_sframe_func_with_fres (sframe_decoder_ctx *sfd_ctx,
const char *ra_mangled_p_str
= ((sframe_fre_get_ra_mangled_p (sfd_ctx, &fre, &err[2]))
? "[s]" : " ");
- size_t ra_mangled_p_str_size = strlen (ra_mangled_p_str);
- strncat (temp, ra_mangled_p_str, ra_mangled_p_str_size);
+ strcat (temp, ra_mangled_p_str);
printf ("%-13s", temp);
}
}
--
2.37.2
reply other threads:[~2023-01-10 18:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110182745.3641128-1-indu.bhagat@oracle.com \
--to=indu.bhagat@oracle.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).