From: "H.J. Lu" <hjl.tools@gmail.com>
To: binutils@sourceware.org
Subject: [PATCH] i386: Pass -Wl,--no-as-needed to compiler as needed
Date: Wed, 25 Jan 2023 09:07:25 -0800 [thread overview]
Message-ID: <20230125170725.386430-1-hjl.tools@gmail.com> (raw)
Pass -Wl,--no-as-needed to linker tests to fix
FAIL: Run pr19031
FAIL: Run got1
FAIL: Undefined weak symbol (-fPIE -no-pie)
FAIL: Undefined weak symbol (-fPIE -pie)
when --as-needed is passed to linker by compiler.
PR ld/30050
* testsuite/ld-i386/i386.exp: Pass -Wl,--no-as-needed to compiler
as needed.
---
ld/testsuite/ld-i386/i386.exp | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/ld/testsuite/ld-i386/i386.exp b/ld/testsuite/ld-i386/i386.exp
index 89e8aee237c..5f53bcf29bc 100644
--- a/ld/testsuite/ld-i386/i386.exp
+++ b/ld/testsuite/ld-i386/i386.exp
@@ -577,7 +577,8 @@ proc undefined_weak {cflags ldflags} {
run_ld_link_exec_tests [list \
[list \
"Run pr19704" \
- "$ldflags tmpdir/libpr19704.so -Wl,-R,tmpdir" \
+ "$ldflags -Wl,--no-as-needed tmpdir/libpr19704.so \
+ -Wl,-R,tmpdir" \
"-Wa,-mrelax-relocations=yes" \
{ pr19704a.c } \
"pr19704" \
@@ -1078,7 +1079,7 @@ if { [isnative]
] \
[list \
"Run pr19031" \
- "$NOPIE_LDFLAGS tmpdir/pr19031.so" \
+ "$NOPIE_LDFLAGS -Wl,--no-as-needed tmpdir/pr19031.so" \
"-Wa,-mx86-used-note=yes" \
{ pr19031b.S pr19031c.c } \
"pr19031" \
@@ -1087,7 +1088,7 @@ if { [isnative]
] \
[list \
"Run got1" \
- "$NOPIE_LDFLAGS tmpdir/got1d.so" \
+ "$NOPIE_LDFLAGS -Wl,--no-as-needed tmpdir/got1d.so" \
"-Wa,-mx86-used-note=yes" \
{ got1a.S got1b.c got1c.c } \
"got1" \
--
2.39.1
next reply other threads:[~2023-01-25 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 17:07 H.J. Lu [this message]
2023-01-26 7:41 ` Jan Beulich
2023-01-26 15:41 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125170725.386430-1-hjl.tools@gmail.com \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).