From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] i386: Pass -Wl,--no-as-needed to compiler as needed
Date: Thu, 26 Jan 2023 07:41:43 -0800 [thread overview]
Message-ID: <CAMe9rOqVRUkeFdDp+nZRm-MaRvcua7UPSG5kMLcnO62=V1wSGA@mail.gmail.com> (raw)
In-Reply-To: <d58f103a-f678-b3a6-6899-e75553eceb12@suse.com>
On Wed, Jan 25, 2023 at 11:41 PM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 25.01.2023 18:07, H.J. Lu via Binutils wrote:
> > Pass -Wl,--no-as-needed to linker tests to fix
> >
> > FAIL: Run pr19031
> > FAIL: Run got1
These 2 failed to link when --as-needed is passed to linker by compiler.
The shared library is ignored by linker since it is placed before the .o files.
> > FAIL: Undefined weak symbol (-fPIE -no-pie)
> > FAIL: Undefined weak symbol (-fPIE -pie)
These 2 failed at run-time when --as-needed is passed to linker by compiler.
The shared library is ignored by linker since it is placed before the .o files.
> How come these four don't match (even in count) ...
>
> > --- a/ld/testsuite/ld-i386/i386.exp
> > +++ b/ld/testsuite/ld-i386/i386.exp
> > @@ -577,7 +577,8 @@ proc undefined_weak {cflags ldflags} {
> > run_ld_link_exec_tests [list \
> > [list \
> > "Run pr19704" \
> > - "$ldflags tmpdir/libpr19704.so -Wl,-R,tmpdir" \
> > + "$ldflags -Wl,--no-as-needed tmpdir/libpr19704.so \
> > + -Wl,-R,tmpdir" \
> > "-Wa,-mrelax-relocations=yes" \
> > { pr19704a.c } \
> > "pr19704" \
> > @@ -1078,7 +1079,7 @@ if { [isnative]
> > ] \
> > [list \
> > "Run pr19031" \
> > - "$NOPIE_LDFLAGS tmpdir/pr19031.so" \
> > + "$NOPIE_LDFLAGS -Wl,--no-as-needed tmpdir/pr19031.so" \
> > "-Wa,-mx86-used-note=yes" \
> > { pr19031b.S pr19031c.c } \
> > "pr19031" \
> > @@ -1087,7 +1088,7 @@ if { [isnative]
> > ] \
> > [list \
> > "Run got1" \
> > - "$NOPIE_LDFLAGS tmpdir/got1d.so" \
> > + "$NOPIE_LDFLAGS -Wl,--no-as-needed tmpdir/got1d.so" \
> > "-Wa,-mx86-used-note=yes" \
> > { got1a.S got1b.c got1c.c } \
> > "got1" \
>
> ... the three tests (with the "Run ..." even visible in context)? Also
> it would have helped if you said a word on what it is that breaks with
> --as-needed. After all there might also be the option of adjusting
> overly strict expectations. (It is always somewhat questionable to
> "fight" compiler defaults by further command line overrides. That's not
> to say it's always the extra override which is wrong; sometimes it's
> also the compiler default which is to be put under question.)
>
> Jan
--
H.J.
prev parent reply other threads:[~2023-01-26 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 17:07 H.J. Lu
2023-01-26 7:41 ` Jan Beulich
2023-01-26 15:41 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOqVRUkeFdDp+nZRm-MaRvcua7UPSG5kMLcnO62=V1wSGA@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).