From: Ilya Leoshkevich <iii@linux.ibm.com>
To: binutils@sourceware.org
Cc: Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PATCH] gas: fix building tc-bpf.c on s390x
Date: Thu, 27 Apr 2023 14:56:07 +0200 [thread overview]
Message-ID: <20230427125607.362035-1-iii@linux.ibm.com> (raw)
char is unsigned on s390x, so there are a lot of warnings like:
gas/config/tc-bpf.c: In function 'get_token':
gas/config/tc-bpf.c:900:14: error: comparison is always false due to limited range of data type [-Werror=type-limits]
900 | if (ch == EOF || len > MAX_TOKEN_SZ)
| ^~
Make ch explicitly signed.
There is also:
gas/config/tc-bpf.c:735:30: error: 'bpf_endianness' may be used uninitialized in this function [-Werror=maybe-uninitialized]
735 | dst, be ? size[endianness - BPF_BE16] : size[endianness - BPF_LE16]);
| ~~~~~~~~~~~^~~~~~~~~~
-Wmaybe-uninitialized doesn't seem to understand the FSM; just
initialize bpf_endianness to silence it.
---
gas/config/tc-bpf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gas/config/tc-bpf.c b/gas/config/tc-bpf.c
index 171fc682806..adcf5edc645 100644
--- a/gas/config/tc-bpf.c
+++ b/gas/config/tc-bpf.c
@@ -885,7 +885,7 @@ get_token (const char **insn, char *token, size_t *tlen)
} while (0)
const char *str = *insn;
- char ch, ch2 = 0;
+ signed char ch, ch2 = 0;
enum bpf_token_type ttype = BPF_UNKNOWN;
size_t len = 0;
const char *expr = NULL;
@@ -1362,7 +1362,7 @@ bpf_pseudoc_to_normal_syntax (const char *str, char **errmsg)
} while (0)
enum bpf_token_type ttype;
- enum bpf_token_type bpf_endianness,
+ enum bpf_token_type bpf_endianness = BPF_UNKNOWN,
bpf_atomic_insn;
enum bpf_token_type bpf_jmp_op = BPF_JEQ; /* Arbitrary. */
enum bpf_token_type bpf_cast = BPF_CAST_U8; /* Arbitrary. */
--
2.40.0
next reply other threads:[~2023-04-27 13:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 12:56 Ilya Leoshkevich [this message]
2023-04-28 6:42 ` Jan Beulich
2023-04-28 9:37 ` Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427125607.362035-1-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).