* [PATCH] tests: force non-deterministic mode in non-deterministic tests
@ 2023-12-18 20:14 Stephen Kitt
2023-12-19 10:30 ` Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Kitt @ 2023-12-18 20:14 UTC (permalink / raw)
To: binutils; +Cc: Stephen Kitt
Since ar can be built defaulting to deterministic mode, tests which
expect non-deterministic behaviour need to explicitly set the U flag.
Signed-off-by: Stephen Kitt <steve@sk2.org>
---
binutils/testsuite/binutils-all/ar.exp | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/binutils/testsuite/binutils-all/ar.exp b/binutils/testsuite/binutils-all/ar.exp
index aade419344e..e65cad8e695 100644
--- a/binutils/testsuite/binutils-all/ar.exp
+++ b/binutils/testsuite/binutils-all/ar.exp
@@ -581,7 +581,7 @@ proc replacing_non_deterministic_member { } {
# Build the archive with the *newer* object file.
- set got [binutils_run $AR "rc $archive ${newer_objfile}"]
+ set got [binutils_run $AR "rcU $archive ${newer_objfile}"]
if ![string match "" $got] {
fail "$testname: (could not build archive)"
return
@@ -589,7 +589,7 @@ proc replacing_non_deterministic_member { } {
# Now try to replace the newer file with the older one. This should not work.
- set got [binutils_run $AR "ru $archive $older_objfile"]
+ set got [binutils_run $AR "ruU $archive $older_objfile"]
if ![string match "" $got] {
fail "$testname: (failed to replace file)"
return
@@ -651,7 +651,7 @@ proc replacing_sde_deterministic_member { } {
# Build the archive with the *newer* object file.
setenv SOURCE_DATE_EPOCH "1000"
- set got [binutils_run $AR "rc $archive ${newer_objfile}"]
+ set got [binutils_run $AR "rcU $archive ${newer_objfile}"]
if ![string match "" $got] {
fail "$testname: (could not build archive)"
unsetenv SOURCE_DATE_EPOCH
@@ -662,7 +662,7 @@ proc replacing_sde_deterministic_member { } {
# archive this will not work, but one created to be deterministic
# should always replace its members.
- set got [binutils_run $AR "ru $archive $older_objfile"]
+ set got [binutils_run $AR "ruU $archive $older_objfile"]
if ![string match "" $got] {
fail "$testname: (failed to replace file)"
unsetenv SOURCE_DATE_EPOCH
base-commit: c4fb39bb31a53bbb2df3be3200d694f025c5b892
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tests: force non-deterministic mode in non-deterministic tests
2023-12-18 20:14 [PATCH] tests: force non-deterministic mode in non-deterministic tests Stephen Kitt
@ 2023-12-19 10:30 ` Jan Beulich
2023-12-19 21:51 ` Stephen Kitt
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2023-12-19 10:30 UTC (permalink / raw)
To: Stephen Kitt; +Cc: binutils
On 18.12.2023 21:14, Stephen Kitt wrote:
> Since ar can be built defaulting to deterministic mode, tests which
> expect non-deterministic behaviour need to explicitly set the U flag.
>
> Signed-off-by: Stephen Kitt <steve@sk2.org>
Okay. I assume this wants committing on your behalf?
Jan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tests: force non-deterministic mode in non-deterministic tests
2023-12-19 10:30 ` Jan Beulich
@ 2023-12-19 21:51 ` Stephen Kitt
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Kitt @ 2023-12-19 21:51 UTC (permalink / raw)
To: Jan Beulich; +Cc: binutils
[-- Attachment #1: Type: text/plain, Size: 484 bytes --]
On Tue, 19 Dec 2023 11:30:28 +0100, Jan Beulich <jbeulich@suse.com> wrote:
> On 18.12.2023 21:14, Stephen Kitt wrote:
> > Since ar can be built defaulting to deterministic mode, tests which
> > expect non-deterministic behaviour need to explicitly set the U flag.
> >
> > Signed-off-by: Stephen Kitt <steve@sk2.org>
>
> Okay. I assume this wants committing on your behalf?
Yes please, but there’s a piece missing, I’ll send a v2 in a moment.
Regards,
Stephen
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-19 21:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-18 20:14 [PATCH] tests: force non-deterministic mode in non-deterministic tests Stephen Kitt
2023-12-19 10:30 ` Jan Beulich
2023-12-19 21:51 ` Stephen Kitt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).