public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Fix loongarch*-elf target gld testsuite failure.
@ 2023-12-27  9:38 Lulu Cai
  2023-12-28  6:18 ` [PATCH] Fix loongarch*-elf target ld " Lulu Cai
  0 siblings, 1 reply; 2+ messages in thread
From: Lulu Cai @ 2023-12-27  9:38 UTC (permalink / raw)
  To: binutils
  Cc: xuchenghua, chenglulu, liuzhensong, mengqinggang, xry111,
	i.swmail, maskray, luweining, wanglei, hejinyang, nickc,
	Lulu Cai

The loongarch*-elf target does not support SHARED and PIE, so this
target is skipped for some tests that require these options.
---
 ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp | 10 +++++++---
 ld/testsuite/ld-loongarch-elf/local-ifunc-reloc.d  |  1 +
 ld/testsuite/ld-loongarch-elf/relax.exp            |  4 ++++
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp b/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
index 2a5709a5b55..460efb1fa1d 100644
--- a/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
+++ b/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
@@ -42,8 +42,9 @@ if [istarget "loongarch32-*-*"] {
     run_dump_test "disas-jirl-32"
 }
 
-if [istarget "loongarch64-*-*"] {
-  run_ld_link_tests \
+if [check_shared_lib_support] {
+  if [istarget "loongarch64-*-*"] {
+    run_ld_link_tests \
       [list \
 	  [list \
 	      "64_pcrel" \
@@ -56,6 +57,8 @@ if [istarget "loongarch64-*-*"] {
 	      "64_pcrel" \
 	  ] \
       ]
+  }
+}
 
   run_ld_link_tests \
       [list \
@@ -68,13 +71,14 @@ if [istarget "loongarch64-*-*"] {
 	      "medium-call" \
 	  ] \
       ]
-}
 
 if [istarget "loongarch64-*-*"] {
+  if [check_shared_lib_support] {
     run_dump_test "desc-ie"
     run_dump_test "desc-le"
     run_dump_test "ie-le"
     run_dump_test "tlsdesc-dso"
     run_dump_test "desc-norelax"
     run_dump_test "desc-relax"
+  }
 }
diff --git a/ld/testsuite/ld-loongarch-elf/local-ifunc-reloc.d b/ld/testsuite/ld-loongarch-elf/local-ifunc-reloc.d
index bf73d9f2875..8e1d3f0d266 100644
--- a/ld/testsuite/ld-loongarch-elf/local-ifunc-reloc.d
+++ b/ld/testsuite/ld-loongarch-elf/local-ifunc-reloc.d
@@ -1,6 +1,7 @@
 #as:
 #ld: -shared -z combreloc
 #objdump: -R
+#skip: loongarch*-elf
 
 .*: +file format .*
 
diff --git a/ld/testsuite/ld-loongarch-elf/relax.exp b/ld/testsuite/ld-loongarch-elf/relax.exp
index 77323d8d7a3..d0faa23c57a 100644
--- a/ld/testsuite/ld-loongarch-elf/relax.exp
+++ b/ld/testsuite/ld-loongarch-elf/relax.exp
@@ -68,6 +68,7 @@ if [istarget loongarch64-*-*] {
       }
     }
 
+  if [check_shared_lib_support] {
     run_ld_link_tests \
 	[list \
 	    [list \
@@ -114,8 +115,10 @@ if [istarget loongarch64-*-*] {
 		"relax-segment-max" \
 	    ] \
 	]
+    }
   }
 
+  if [check_shared_lib_support] {
   run_ld_link_tests \
       [list \
 	  [list \
@@ -129,6 +132,7 @@ if [istarget loongarch64-*-*] {
 	      "relax-align" \
 	  ] \
       ]
+  }
 
   set objdump_flags "-s -j .data"
   run_ld_link_tests \
-- 
2.36.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] Fix loongarch*-elf target ld testsuite failure.
  2023-12-27  9:38 [PATCH] Fix loongarch*-elf target gld testsuite failure Lulu Cai
@ 2023-12-28  6:18 ` Lulu Cai
  0 siblings, 0 replies; 2+ messages in thread
From: Lulu Cai @ 2023-12-28  6:18 UTC (permalink / raw)
  To: binutils
  Cc: xuchenghua, chenglulu, liuzhensong, mengqinggang, xry111,
	i.swmail, maskray, luweining, wanglei, hejinyang, nickc,
	Lulu Cai

The loongarch*-elf target does not support SHARED and PIE, so this
target is skipped for some tests that require these options.
---
 .../ld-loongarch-elf/ld-loongarch-elf.exp     | 30 +++++++++++--------
 .../ld-loongarch-elf/local-ifunc-reloc.d      |  1 +
 ld/testsuite/ld-loongarch-elf/relax.exp       |  4 +++
 3 files changed, 22 insertions(+), 13 deletions(-)

diff --git a/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp b/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
index 2a5709a5b55..8dc04fea707 100644
--- a/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
+++ b/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
@@ -43,19 +43,21 @@ if [istarget "loongarch32-*-*"] {
 }
 
 if [istarget "loongarch64-*-*"] {
-  run_ld_link_tests \
-      [list \
-	  [list \
-	      "64_pcrel" \
-	      "-e 0x0 -z relro" "" \
-	      "" \
-	      {64_pcrel.s} \
-	      [list \
-		  [list objdump -D 64_pcrel.d] \
-	      ] \
-	      "64_pcrel" \
-	  ] \
-      ]
+  if [check_shared_lib_support] {
+    run_ld_link_tests \
+	[list \
+	    [list \
+		"64_pcrel" \
+		"-e 0x0 -z relro" "" \
+		"" \
+		{64_pcrel.s} \
+		[list \
+		    [list objdump -D 64_pcrel.d] \
+		] \
+		"64_pcrel" \
+	    ] \
+	]
+  }
 
   run_ld_link_tests \
       [list \
@@ -71,10 +73,12 @@ if [istarget "loongarch64-*-*"] {
 }
 
 if [istarget "loongarch64-*-*"] {
+  if [check_shared_lib_support] {
     run_dump_test "desc-ie"
     run_dump_test "desc-le"
     run_dump_test "ie-le"
     run_dump_test "tlsdesc-dso"
     run_dump_test "desc-norelax"
     run_dump_test "desc-relax"
+  }
 }
diff --git a/ld/testsuite/ld-loongarch-elf/local-ifunc-reloc.d b/ld/testsuite/ld-loongarch-elf/local-ifunc-reloc.d
index bf73d9f2875..8e1d3f0d266 100644
--- a/ld/testsuite/ld-loongarch-elf/local-ifunc-reloc.d
+++ b/ld/testsuite/ld-loongarch-elf/local-ifunc-reloc.d
@@ -1,6 +1,7 @@
 #as:
 #ld: -shared -z combreloc
 #objdump: -R
+#skip: loongarch*-elf
 
 .*: +file format .*
 
diff --git a/ld/testsuite/ld-loongarch-elf/relax.exp b/ld/testsuite/ld-loongarch-elf/relax.exp
index 77323d8d7a3..d0faa23c57a 100644
--- a/ld/testsuite/ld-loongarch-elf/relax.exp
+++ b/ld/testsuite/ld-loongarch-elf/relax.exp
@@ -68,6 +68,7 @@ if [istarget loongarch64-*-*] {
       }
     }
 
+  if [check_shared_lib_support] {
     run_ld_link_tests \
 	[list \
 	    [list \
@@ -114,8 +115,10 @@ if [istarget loongarch64-*-*] {
 		"relax-segment-max" \
 	    ] \
 	]
+    }
   }
 
+  if [check_shared_lib_support] {
   run_ld_link_tests \
       [list \
 	  [list \
@@ -129,6 +132,7 @@ if [istarget loongarch64-*-*] {
 	      "relax-align" \
 	  ] \
       ]
+  }
 
   set objdump_flags "-s -j .data"
   run_ld_link_tests \
-- 
2.36.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-12-28  6:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-27  9:38 [PATCH] Fix loongarch*-elf target gld testsuite failure Lulu Cai
2023-12-28  6:18 ` [PATCH] Fix loongarch*-elf target ld " Lulu Cai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).