From: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>
To: binutils@sourceware.org
Cc: cailulu@loongson.cn, chenglulu@loongson.cn,
hejinyang@loongson.cn, i.swmail@xen0n.name,
liuzhensong@loongson.cn, luweining@loongson.cn,
maskray@google.com, mengqinggang@loongson.cn, nickc@redhat.com,
wanglei@loongson.cn, xry111@xry111.site, xuchenghua@loongson.cn,
Tatsuyuki Ishi <ishitatsuyuki@gmail.com>
Subject: [PATCH] LoongArch: Do not add DF_STATIC_TLS for TLS LE
Date: Thu, 28 Dec 2023 23:58:00 +0900 [thread overview]
Message-ID: <20231228145802.74719-1-ishitatsuyuki@gmail.com> (raw)
TLS LE is exclusively for executables, while DF_STATIC_TLS is for DLLs.
DF_STATIC_TLS should only be set for TLS IE (and when it's DLL), not LE.
---
bfd/elfnn-loongarch.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
index bd448cda453..64c34e99261 100644
--- a/bfd/elfnn-loongarch.c
+++ b/bfd/elfnn-loongarch.c
@@ -862,8 +862,6 @@ loongarch_elf_check_relocs (bfd *abfd, struct bfd_link_info *info,
if (!bfd_link_executable (info))
return false;
- info->flags |= DF_STATIC_TLS;
-
if (!loongarch_elf_record_tls_and_got_reference (abfd, info, h,
r_symndx,
GOT_TLS_LE))
--
2.40.1
next reply other threads:[~2023-12-28 14:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 14:58 Tatsuyuki Ishi [this message]
2023-12-28 14:58 ` [PATCH] LoongArch: Use tab to indent assembly in TLSDESC test suite Tatsuyuki Ishi
2024-01-22 9:47 ` mengqinggang
2023-12-28 14:58 ` [PATCH] LoongArch: Update comment about bottom bit usage in TLS GOT construction Tatsuyuki Ishi
2023-12-29 8:50 ` mengqinggang
2023-12-29 9:11 ` Tatsuyuki Ishi
2023-12-29 9:59 ` mengqinggang
2024-01-22 5:45 ` [PATCH] LoongArch: Do not add DF_STATIC_TLS for TLS LE Tatsuyuki Ishi
2024-01-22 5:48 ` Fangrui Song
2024-01-22 6:51 ` Xi Ruoyao
2024-01-22 7:11 ` Fangrui Song
2024-01-22 8:27 ` mengqinggang
2024-01-22 9:46 ` mengqinggang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231228145802.74719-1-ishitatsuyuki@gmail.com \
--to=ishitatsuyuki@gmail.com \
--cc=binutils@sourceware.org \
--cc=cailulu@loongson.cn \
--cc=chenglulu@loongson.cn \
--cc=hejinyang@loongson.cn \
--cc=i.swmail@xen0n.name \
--cc=liuzhensong@loongson.cn \
--cc=luweining@loongson.cn \
--cc=maskray@google.com \
--cc=mengqinggang@loongson.cn \
--cc=nickc@redhat.com \
--cc=wanglei@loongson.cn \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).