From: mengqinggang <mengqinggang@loongson.cn>
To: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>, binutils@sourceware.org
Cc: cailulu@loongson.cn, chenglulu@loongson.cn,
hejinyang@loongson.cn, i.swmail@xen0n.name,
liuzhensong@loongson.cn, luweining@loongson.cn,
maskray@google.com, nickc@redhat.com, wanglei@loongson.cn,
xry111@xry111.site, xuchenghua@loongson.cn
Subject: Re: [PATCH] LoongArch: Use tab to indent assembly in TLSDESC test suite
Date: Mon, 22 Jan 2024 17:47:07 +0800 [thread overview]
Message-ID: <513a758a-2115-60d6-4cc8-f714e4adcc81@loongson.cn> (raw)
In-Reply-To: <20231228145802.74719-2-ishitatsuyuki@gmail.com>
Thank you very much, it has been applied.
在 2023/12/28 下午10:58, Tatsuyuki Ishi 写道:
> The usual convention is to use tabs. Not all test are following this,
> but at least when using tabs, let's use it consistently throughout the
> file.
> ---
> gas/testsuite/gas/loongarch/tlsdesc_32.s | 2 +-
> gas/testsuite/gas/loongarch/tlsdesc_64.s | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gas/testsuite/gas/loongarch/tlsdesc_32.s b/gas/testsuite/gas/loongarch/tlsdesc_32.s
> index ef6aee94fbb..2a139c041b1 100644
> --- a/gas/testsuite/gas/loongarch/tlsdesc_32.s
> +++ b/gas/testsuite/gas/loongarch/tlsdesc_32.s
> @@ -4,7 +4,7 @@
> # R_LARCH_TLS_DESC_PC_LO12 var
> addi.w $a0,$a0,%desc_pc_lo12(var)
> # R_LARCH_TLS_DESC_LD var
> - ld.w $ra,$a0,%desc_ld(var)
> + ld.w $ra,$a0,%desc_ld(var)
> # R_LARCH_TLS_DESC_CALL var
> jirl $ra,$ra,%desc_call(var)
>
> diff --git a/gas/testsuite/gas/loongarch/tlsdesc_64.s b/gas/testsuite/gas/loongarch/tlsdesc_64.s
> index 9d0ccb170ad..9850940ef93 100644
> --- a/gas/testsuite/gas/loongarch/tlsdesc_64.s
> +++ b/gas/testsuite/gas/loongarch/tlsdesc_64.s
> @@ -4,7 +4,7 @@
> # R_LARCH_TLS_DESC_PC_LO12 var
> addi.d $a0,$a0,%desc_pc_lo12(var)
> # R_LARCH_TLS_DESC_LD var
> - ld.d $ra,$a0,%desc_ld(var)
> + ld.d $ra,$a0,%desc_ld(var)
> # R_LARCH_TLS_DESC_CALL var
> jirl $ra,$ra,%desc_call(var)
>
next prev parent reply other threads:[~2024-01-22 9:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 14:58 [PATCH] LoongArch: Do not add DF_STATIC_TLS for TLS LE Tatsuyuki Ishi
2023-12-28 14:58 ` [PATCH] LoongArch: Use tab to indent assembly in TLSDESC test suite Tatsuyuki Ishi
2024-01-22 9:47 ` mengqinggang [this message]
2023-12-28 14:58 ` [PATCH] LoongArch: Update comment about bottom bit usage in TLS GOT construction Tatsuyuki Ishi
2023-12-29 8:50 ` mengqinggang
2023-12-29 9:11 ` Tatsuyuki Ishi
2023-12-29 9:59 ` mengqinggang
2024-01-22 5:45 ` [PATCH] LoongArch: Do not add DF_STATIC_TLS for TLS LE Tatsuyuki Ishi
2024-01-22 5:48 ` Fangrui Song
2024-01-22 6:51 ` Xi Ruoyao
2024-01-22 7:11 ` Fangrui Song
2024-01-22 8:27 ` mengqinggang
2024-01-22 9:46 ` mengqinggang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513a758a-2115-60d6-4cc8-f714e4adcc81@loongson.cn \
--to=mengqinggang@loongson.cn \
--cc=binutils@sourceware.org \
--cc=cailulu@loongson.cn \
--cc=chenglulu@loongson.cn \
--cc=hejinyang@loongson.cn \
--cc=i.swmail@xen0n.name \
--cc=ishitatsuyuki@gmail.com \
--cc=liuzhensong@loongson.cn \
--cc=luweining@loongson.cn \
--cc=maskray@google.com \
--cc=nickc@redhat.com \
--cc=wanglei@loongson.cn \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).