From: Indu Bhagat <indu.bhagat@oracle.com>
To: binutils@sourceware.org
Cc: Indu Bhagat <indu.bhagat@oracle.com>
Subject: [COMMITTED 13/15] opcodes: i386-reg.tbl: Add a comment to reflect dependency on ordering
Date: Mon, 15 Jan 2024 04:07:27 -0800 [thread overview]
Message-ID: <20240115120729.29771-14-indu.bhagat@oracle.com> (raw)
In-Reply-To: <20240115120729.29771-1-indu.bhagat@oracle.com>
The ginsn representation keeps the DWARF register number of the
operands. The API ginsn_dw2_regnum relies on the the relative ordering
of these register entries in the table. Add a comment to make it clear.
opcodes/
* i386-reg.tbl: Add a comment.
---
opcodes/i386-reg.tbl | 3 +++
1 file changed, 3 insertions(+)
diff --git a/opcodes/i386-reg.tbl b/opcodes/i386-reg.tbl
index 5b80ee6026e..f92315392b8 100644
--- a/opcodes/i386-reg.tbl
+++ b/opcodes/i386-reg.tbl
@@ -18,6 +18,9 @@
// Software Foundation, 51 Franklin Street - Fifth Floor, Boston, MA
// 02110-1301, USA.
+// The code in gas backend for SCFI relies on the relative ordering
+// of 8 bit / 16 bit / 32 bit / 64 bit regs
+
// 8 bit regs
al, Class=Reg|Instance=Accum|Byte, 0, 0, Dw2Inval, Dw2Inval
cl, Class=Reg|Instance=RegC|Byte, 0, 1, Dw2Inval, Dw2Inval
--
2.41.0
next prev parent reply other threads:[~2024-01-15 12:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 12:07 [COMMITTED 00/15] Experimental support for synthesizing CFI for hand-written asm Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 01/15] gas: dw2gencfi: minor rejig for cfi_sections_set and all_cfi_sections Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 02/15] gas: dw2gencfi: use all_cfi_sections instead of cfi_sections Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 03/15] gas: dw2gencfi: expose a new cfi_set_last_fde API Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 04/15] gas: dw2gencfi: move some tc_* defines to the header file Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 05/15] gas: dw2gencfi: expose dot_cfi_sections for scfidw2gen Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 06/15] gas: dw2gencfi: externalize the all_cfi_sections Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 07/15] gas: add new command line option --scfi=experimental Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 08/15] gas: scfidw2gen: new functionality to prepare for SCFI Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 09/15] opcodes: gas: x86: define and use Rex2 as attribute not constraint Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 10/15] opcodes: x86: new marker for insns that implicitly update stack pointer Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 11/15] gas: x86: synthesize CFI for hand-written asm Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 12/15] gas: doc: update documentation for the new listing option Indu Bhagat
2024-01-15 12:07 ` Indu Bhagat [this message]
2024-01-15 12:07 ` [COMMITTED 14/15] gas: testsuite: add an x86 testsuite for SCFI Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 15/15] gas/NEWS: announce the new SCFI command line option Indu Bhagat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240115120729.29771-14-indu.bhagat@oracle.com \
--to=indu.bhagat@oracle.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).