From: Indu Bhagat <indu.bhagat@oracle.com>
To: binutils@sourceware.org
Cc: Indu Bhagat <indu.bhagat@oracle.com>
Subject: [COMMITTED 02/15] gas: dw2gencfi: use all_cfi_sections instead of cfi_sections
Date: Mon, 15 Jan 2024 04:07:16 -0800 [thread overview]
Message-ID: <20240115120729.29771-3-indu.bhagat@oracle.com> (raw)
In-Reply-To: <20240115120729.29771-1-indu.bhagat@oracle.com>
The code in dw2gencfi.c was checking variable cfi_sections and
all_cfi_sections seemingly randomly. Accessing all_cfi_sections seems
to the correct variable to access.
The data in cfi_sections has already been propagated to all_cfi_sections
once cfi_dot_startproc () has been called.
gas/
* dw2gencfi.c (dot_cfi_startproc): Use all_cfi_sections
instead.
(dot_cfi_endproc): Likewise.
(dot_cfi_fde_data): Likewise.
---
gas/dw2gencfi.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gas/dw2gencfi.c b/gas/dw2gencfi.c
index 01cde827f63..eccfd6470c2 100644
--- a/gas/dw2gencfi.c
+++ b/gas/dw2gencfi.c
@@ -1316,7 +1316,7 @@ dot_cfi_startproc (int ignored ATTRIBUTE_UNUSED)
if (!simple)
tc_cfi_frame_initial_instructions ();
- if ((cfi_sections & CFI_EMIT_target) != 0)
+ if ((all_cfi_sections & CFI_EMIT_target) != 0)
tc_cfi_startproc ();
}
@@ -1336,7 +1336,7 @@ dot_cfi_endproc (int ignored ATTRIBUTE_UNUSED)
demand_empty_rest_of_line ();
- if ((cfi_sections & CFI_EMIT_target) != 0)
+ if ((all_cfi_sections & CFI_EMIT_target) != 0)
tc_cfi_endproc (last_fde);
}
@@ -1417,8 +1417,8 @@ dot_cfi_fde_data (int ignored ATTRIBUTE_UNUSED)
last_fde = frchain_now->frch_cfi_data->cur_fde_data;
- if ((cfi_sections & CFI_EMIT_target) != 0
- || (cfi_sections & CFI_EMIT_eh_frame_compact) != 0)
+ if ((all_cfi_sections & CFI_EMIT_target) != 0
+ || (all_cfi_sections & CFI_EMIT_eh_frame_compact) != 0)
{
struct cfi_escape_data *head, **tail, *e;
int num_ops = 0;
--
2.41.0
next prev parent reply other threads:[~2024-01-15 12:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 12:07 [COMMITTED 00/15] Experimental support for synthesizing CFI for hand-written asm Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 01/15] gas: dw2gencfi: minor rejig for cfi_sections_set and all_cfi_sections Indu Bhagat
2024-01-15 12:07 ` Indu Bhagat [this message]
2024-01-15 12:07 ` [COMMITTED 03/15] gas: dw2gencfi: expose a new cfi_set_last_fde API Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 04/15] gas: dw2gencfi: move some tc_* defines to the header file Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 05/15] gas: dw2gencfi: expose dot_cfi_sections for scfidw2gen Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 06/15] gas: dw2gencfi: externalize the all_cfi_sections Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 07/15] gas: add new command line option --scfi=experimental Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 08/15] gas: scfidw2gen: new functionality to prepare for SCFI Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 09/15] opcodes: gas: x86: define and use Rex2 as attribute not constraint Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 10/15] opcodes: x86: new marker for insns that implicitly update stack pointer Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 11/15] gas: x86: synthesize CFI for hand-written asm Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 12/15] gas: doc: update documentation for the new listing option Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 13/15] opcodes: i386-reg.tbl: Add a comment to reflect dependency on ordering Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 14/15] gas: testsuite: add an x86 testsuite for SCFI Indu Bhagat
2024-01-15 12:07 ` [COMMITTED 15/15] gas/NEWS: announce the new SCFI command line option Indu Bhagat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240115120729.29771-3-indu.bhagat@oracle.com \
--to=indu.bhagat@oracle.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).