public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Indu Bhagat <indu.bhagat@oracle.com>
To: binutils@sourceware.org
Cc: Indu Bhagat <indu.bhagat@oracle.com>
Subject: [PATCH,V2 0/2] Testcase refactoring and fix PR gas/31284
Date: Tue, 23 Jan 2024 23:26:27 -0800	[thread overview]
Message-ID: <20240124072629.1193542-1-indu.bhagat@oracle.com> (raw)

Hi,

When fixing PR gas/31284, I realised that the existing testcase for
change of flow instructions could use some refactoring.

I think applying the two patches to binutils 2.42 branch may be a good
idea because issuing an error is a clearer message than the previous
warning.  More details in the commit log of Patch 2/2.  What is your
opinion ?

Thanks,
Indu Bhagat (2):
  x86: testsuite: scfi: adjust COFI testcase
  gas: scfi: untraceable control flow should be a hard error

 gas/ginsn.c                                   |  4 +-
 gas/testsuite/gas/scfi/x86_64/ginsn-cofi-1.l  | 38 +++++++++++++++++++
 .../x86_64/{scfi-cofi-1.s => ginsn-cofi-1.s}  |  4 --
 gas/testsuite/gas/scfi/x86_64/scfi-cofi-1.d   |  5 ---
 gas/testsuite/gas/scfi/x86_64/scfi-cofi-1.l   |  3 --
 .../gas/scfi/x86_64/scfi-unsupported-cfg-1.l  |  2 +-
 gas/testsuite/gas/scfi/x86_64/scfi-x86-64.exp |  3 +-
 7 files changed, 42 insertions(+), 17 deletions(-)
 create mode 100644 gas/testsuite/gas/scfi/x86_64/ginsn-cofi-1.l
 rename gas/testsuite/gas/scfi/x86_64/{scfi-cofi-1.s => ginsn-cofi-1.s} (84%)
 delete mode 100644 gas/testsuite/gas/scfi/x86_64/scfi-cofi-1.d
 delete mode 100644 gas/testsuite/gas/scfi/x86_64/scfi-cofi-1.l

-- 
2.43.0


             reply	other threads:[~2024-01-24  7:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24  7:26 Indu Bhagat [this message]
2024-01-24  7:26 ` [PATCH,V2 1/2] x86: testsuite: scfi: adjust COFI testcase Indu Bhagat
2024-01-25 15:46   ` Jan Beulich
2024-01-24  7:26 ` [PATCH,V2 2/2] gas: scfi: untraceable control flow should be a hard error Indu Bhagat
2024-01-25 13:59   ` [PATCH, V2 " Jan Beulich
2024-01-25 19:43     ` Indu Bhagat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240124072629.1193542-1-indu.bhagat@oracle.com \
    --to=indu.bhagat@oracle.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).