From: Jan Beulich <jbeulich@suse.com>
To: Indu Bhagat <indu.bhagat@oracle.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH,V2 1/2] x86: testsuite: scfi: adjust COFI testcase
Date: Thu, 25 Jan 2024 16:46:22 +0100 [thread overview]
Message-ID: <98c76921-65eb-44cc-bb2c-4f4df257c91e@suse.com> (raw)
In-Reply-To: <20240124072629.1193542-2-indu.bhagat@oracle.com>
On 24.01.2024 08:26, Indu Bhagat wrote:
> The testcase for change of flow instructions in its current shape is not
> doing much: it checks that SCFI issues an appropriate warning. The same
> warning is covered by another testcase (scfi-unsupported-cfg-1); It is
> better to test the ginsn translation instead, for these 'change of flow
> instructions'.
I trust your judgement here, so feel free to put in.
Jan
next prev parent reply other threads:[~2024-01-25 15:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 7:26 [PATCH,V2 0/2] Testcase refactoring and fix PR gas/31284 Indu Bhagat
2024-01-24 7:26 ` [PATCH,V2 1/2] x86: testsuite: scfi: adjust COFI testcase Indu Bhagat
2024-01-25 15:46 ` Jan Beulich [this message]
2024-01-24 7:26 ` [PATCH,V2 2/2] gas: scfi: untraceable control flow should be a hard error Indu Bhagat
2024-01-25 13:59 ` [PATCH, V2 " Jan Beulich
2024-01-25 19:43 ` Indu Bhagat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98c76921-65eb-44cc-bb2c-4f4df257c91e@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=indu.bhagat@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).