public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Will Hawkins <hawkinsw@obs.cr>
To: binutils@sourceware.org
Cc: Will Hawkins <hawkinsw@obs.cr>
Subject: [PATCH v2 0/1] Add BPF callx support to objdump and as
Date: Mon, 12 Feb 2024 12:42:05 -0500	[thread overview]
Message-ID: <20240212174209.620310-1-hawkinsw@obs.cr> (raw)
In-Reply-To: 20240209180734.443763-1-hawkinsw@obs.cr

After additional consideration and discussion with Jose and Dave,
it seems like we have determined the way that clang, gcc and binutils
need to handle the callx/callr:

1. callr remains with the register holding the target of the jump stored
in the dst_reg.
2. callx is added with the register holding the target of the jump stored
in the imm32.
3. We have to remove the pseudoc syntax because it is no longer possible
to disambiguate between versions of call by simply looking at the parameter.

Tests are added/refactored to meet the above. 

I am more than happy to resend as a separate mailing to the list but
sending first as a reply in order to keep list traffic manageable.

As I said before, I sincerely appreciate all that you are doing for
the community and how welcoming you have been to a first-time contributor.

Sincerely,
Will

Will Hawkins (1):
  objdump, as: Add callx support for BPF CPU v1

 gas/config/tc-bpf.c                           | 25 ++++++++++++++++++-
 gas/testsuite/gas/bpf/bpf.exp                 |  4 +--
 .../gas/bpf/{indcall-1.d => callr.d}          |  4 +--
 .../gas/bpf/{indcall-1.s => callr.s}          |  2 +-
 gas/testsuite/gas/bpf/indcall-1-pseudoc.d     | 23 -----------------
 gas/testsuite/gas/bpf/indcall-1-pseudoc.s     | 13 ----------
 include/opcode/bpf.h                          |  3 ++-
 opcodes/bpf-dis.c                             |  6 +++++
 opcodes/bpf-opc.c                             |  4 ++-
 sim/bpf/bpf-sim.c                             |  4 +++
 10 files changed, 44 insertions(+), 44 deletions(-)
 rename gas/testsuite/gas/bpf/{indcall-1.d => callr.d} (90%)
 rename gas/testsuite/gas/bpf/{indcall-1.s => callr.s} (90%)
 delete mode 100644 gas/testsuite/gas/bpf/indcall-1-pseudoc.d
 delete mode 100644 gas/testsuite/gas/bpf/indcall-1-pseudoc.s

-- 
2.43.0


             reply	other threads:[~2024-02-12 17:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12 17:42 Will Hawkins [this message]
2024-02-12 17:42 ` [PATCH v2 1/1] objdump, as: Add callx support for BPF CPU v1 Will Hawkins
2024-02-13 11:57   ` Nick Clifton
2024-02-14  4:17     ` Will Hawkins
2024-02-14 10:58       ` Jose E. Marchesi
2024-02-14 16:04         ` Will Hawkins
2024-02-14 16:14           ` Jose E. Marchesi
2024-02-14 16:19             ` Will Hawkins
2024-02-15 15:32               ` Jose E. Marchesi
2024-02-15 21:44                 ` Will Hawkins
2024-02-15 10:32       ` Nick Clifton
2024-02-12 18:39 ` [PATCH v2 0/1] Add BPF callx support to objdump and as Jose E. Marchesi
2024-02-12 22:25   ` Will Hawkins
2024-02-12 22:38     ` Will Hawkins
2024-02-12 22:50       ` Yonghong Song
2024-02-12 22:55         ` Will Hawkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240212174209.620310-1-hawkinsw@obs.cr \
    --to=hawkinsw@obs.cr \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).