public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Will Hawkins <hawkinsw@obs.cr>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>
Cc: Nick Clifton <nickc@redhat.com>, binutils@sourceware.org
Subject: Re: [PATCH v2 1/1] objdump, as: Add callx support for BPF CPU v1
Date: Thu, 15 Feb 2024 16:44:08 -0500	[thread overview]
Message-ID: <CADx9qWgnOoJUPmRsFJ9PTtQOOO08kZY6d_RECT6wZjCuPs3ymA@mail.gmail.com> (raw)
In-Reply-To: <87il2pivz7.fsf@oracle.com>

On Thu, Feb 15, 2024 at 10:32 AM Jose E. Marchesi
<jose.marchesi@oracle.com> wrote:
>
>
> > On Wed, Feb 14, 2024 at 11:14 AM Jose E. Marchesi
> > <jose.marchesi@oracle.com> wrote:
> >>
> >>
> >> > On Wed, Feb 14, 2024 at 5:58 AM Jose E. Marchesi
> >> > <jose.marchesi@oracle.com> wrote:
> >> >>
> >> >>
> >> >> > First, as I said yesterday in my direct message to you, thank you for
> >> >> > making binutils such a pleasant place to contribute to FOSS. You have
> >> >> > no idea what that means to contributors like me!
> >> >> >
> >> >> > Second, thank you for this helpful critique. I really appreciated
> >> >> > reading your feedback and will reply inline below (including with an
> >> >> > offer for a patch unrelated to callx that may clean up some of the
> >> >> > non-constant uses throughout the bpf-specific code).
> >> >> >
> >> >> > Third, there is good news: The heavy lifting of this patch is largely
> >> >> > "overcome by events" -- clang/llvm developers are changing their
> >> >> > encoding of the callx instruction to more closely match what gcc does.
> >> >> > In fact, v3 of this patch will look much more like v1 than v2.
> >> >>
> >> >> Hi Will.
> >> >>
> >> >> It seems to me that all we need binutils-wise is to enable the callx
> >> >> instruction with BPF >= v1.  No other changes are necessary as far as I
> >> >> can see, other than adjusting the testsuite accordingly.
> >> >
> >> > It should be making its way across the Internet to you now!
> >>
> >> Thanks :)
> >>
> >> > The only thing ... it will probably cause a build error until a
> >> > corresponding patch in the simulator lands that takes into
> >> > consideration the new enum value.
> >> >
> >> > I am happy to handle that however you like!
> >>
> >> No problem.  I will tackle the simulator patch in the GDB list and apply
> >> both at almost the same time so the buildbots do not get (too) upset.
> >
> > Thanks!! It's been fun working on this. And, as I offered to Nick last
> > night, I am more than happy to take on a little project to do a
> > cleanup of the code. Just let me know if you would be open to that!
>
> By all means, and than you.
> Improvements are always very welcome :)
>
> BTW, I would ask you to not include a separated cover letter for single
> patches.  This makes it easier to reply and quote to both the
> description of the patch and its contents.

Thank you! That's great feedback! I will definitely do that from now on!

Will


>
> >
> > Will
> >
> >>
> >> > Sorry for the delay!
> >> > Will
> >> >
> >> >
> >> >>
> >> >> Thanks!

  reply	other threads:[~2024-02-15 21:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12 17:42 [PATCH v2 0/1] Add BPF callx support to objdump and as Will Hawkins
2024-02-12 17:42 ` [PATCH v2 1/1] objdump, as: Add callx support for BPF CPU v1 Will Hawkins
2024-02-13 11:57   ` Nick Clifton
2024-02-14  4:17     ` Will Hawkins
2024-02-14 10:58       ` Jose E. Marchesi
2024-02-14 16:04         ` Will Hawkins
2024-02-14 16:14           ` Jose E. Marchesi
2024-02-14 16:19             ` Will Hawkins
2024-02-15 15:32               ` Jose E. Marchesi
2024-02-15 21:44                 ` Will Hawkins [this message]
2024-02-15 10:32       ` Nick Clifton
2024-02-12 18:39 ` [PATCH v2 0/1] Add BPF callx support to objdump and as Jose E. Marchesi
2024-02-12 22:25   ` Will Hawkins
2024-02-12 22:38     ` Will Hawkins
2024-02-12 22:50       ` Yonghong Song
2024-02-12 22:55         ` Will Hawkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADx9qWgnOoJUPmRsFJ9PTtQOOO08kZY6d_RECT6wZjCuPs3ymA@mail.gmail.com \
    --to=hawkinsw@obs.cr \
    --cc=binutils@sourceware.org \
    --cc=jose.marchesi@oracle.com \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).