public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Alcock <nick.alcock@oracle.com>
To: binutils@sourceware.org
Subject: [PATCH 0/7] libctf: leak-adjacent fixes
Date: Fri, 26 Apr 2024 21:20:16 +0100	[thread overview]
Message-ID: <20240426202023.423064-1-nick.alcock@oracle.com> (raw)

This series fixes a bad memory leak on a libctf error path, fixes a couple
of smaller problems on the way, and soups up the testsuite a bit to make it
easier to write the rather nasty test that should prevent this leak from
recurring.

I likely won't be committing it for a couple of weeks, and probably not
until I've added more to the series, but this is posted now anyway in case
anyone wants to take a look and e.g. perhaps tell me that my malloc
interposition skills are simply dreadful :)

Nick Alcock (7):
  libctf: typos
  libctf: failure to open parent dicts that exist should be an error
  libctf: ctf_archive_iter: fix tiny leak
  libctf: test: add lookup_link
  libctf: test: add host
  libctf: test: add wrapper
  libctf: fix leak of entire dict when dict opening fails

 libctf/ctf-archive.c                          |  29 ++-
 libctf/ctf-open.c                             |   8 +-
 libctf/testsuite/lib/ctf-lib.exp              |  28 ++-
 .../libctf-regression/open-error-free.c       | 185 ++++++++++++++++++
 .../libctf-regression/open-error-free.lk      |   5 +
 5 files changed, 244 insertions(+), 11 deletions(-)
 create mode 100644 libctf/testsuite/libctf-regression/open-error-free.c
 create mode 100644 libctf/testsuite/libctf-regression/open-error-free.lk

-- 
2.44.0.273.ge0bd14271f


             reply	other threads:[~2024-04-26 20:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-26 20:20 Nick Alcock [this message]
2024-04-26 20:20 ` [PATCH 1/7] libctf: typos Nick Alcock
2024-04-26 20:20 ` [PATCH 2/7] libctf: failure to open parent dicts that exist should be an error Nick Alcock
2024-04-26 20:20 ` [PATCH 3/7] libctf: ctf_archive_iter: fix tiny leak Nick Alcock
2024-04-26 20:20 ` [PATCH 4/7] libctf: test: add lookup_link Nick Alcock
2024-04-26 20:20 ` [PATCH 5/7] libctf: test: add host Nick Alcock
2024-04-26 20:20 ` [PATCH 6/7] libctf: test: add wrapper Nick Alcock
2024-04-26 20:20 ` [PATCH 7/7] libctf: fix leak of entire dict when dict opening fails Nick Alcock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240426202023.423064-1-nick.alcock@oracle.com \
    --to=nick.alcock@oracle.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).