Re: [PATCH 2/2] xcoff: implement linker relaxation

[Nick Clifton <nickc@redhat.com>]

Hi Clement,

   This patch generates a compile time error (using gcc 11.2.1):

bfd/xcofflink.c: In function 'xcoff_stub_get_csect_in_range':
bfd/xcofflink.c:4332:20: error: 'sprintf' may write a terminating nul past the end of the destination [-Werror=format-overflow=]
  4332 |   sprintf (buf, "%d", n);
       |                    ^
bfd/xcofflink.c:4332:3: note: 'sprintf' output between 2 and 7 bytes into a destination of size 6
  4332 |   sprintf (buf, "%d", n);
       |   ^~~~~~~~~~~~~~~~~~~~~~

   I suggest increasing the size of "buf" to at least 8.  In addition
   if you are feeling paranoid, you could use snprintf instead of
   sprintf.

   Other than that though the patch looks good to me, so approved,
   once that above problem has been fixed.

Cheers
   Nick