From: Jan Beulich <jbeulich@suse.com>
To: "Steinar H. Gunderson" <sesse@google.com>
Cc: sesse@chromium.org, binutils@sourceware.org
Subject: Re: [PATCH v4] Add a trie to map quickly from address range to compilation unit.
Date: Fri, 20 May 2022 16:12:48 +0200 [thread overview]
Message-ID: <23e77311-e52d-e972-5fbf-2875fa3f41a0@suse.com> (raw)
In-Reply-To: <YnkGWu0hADsY7TJt@google.com>
On 09.05.2022 14:17, Steinar H. Gunderson via Binutils wrote:
> On Fri, Apr 22, 2022 at 12:25:12PM +0200, Steinar H. Gunderson wrote:
>> When using perf to profile large binaries, _bfd_dwarf2_find_nearest_line()
>> becomes a hotspot, as perf wants to get line number information
>> (for inline-detection purposes) for each and every sample. In Chromium
>> in particular (the content_shell binary), this entails going through
>> 475k address ranges, which takes a long time when done repeatedly.
>
> Any news on getting this pushed?
I've now committed it. In the patch (e.g. as a post-commit-message
remark) there was no indication that this needs taking care of by
someone, so I was going from the assumption that you would have
commit access yourself.
Jan
next prev parent reply other threads:[~2022-05-20 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 10:25 Steinar H. Gunderson
2022-05-09 12:17 ` Steinar H. Gunderson
2022-05-20 14:12 ` Jan Beulich [this message]
2022-05-20 14:16 ` Steinar H. Gunderson
2022-05-20 14:21 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23e77311-e52d-e972-5fbf-2875fa3f41a0@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=sesse@chromium.org \
--cc=sesse@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).