From: Nick Clifton <nickc@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH] gas: Don't error when .debug_line already exists, unless .loc was used
Date: Fri, 11 Sep 2020 16:45:20 +0100 [thread overview]
Message-ID: <24411cad-fc66-bca6-8122-f3580e2d26c2@redhat.com> (raw)
Hi Mark,
> gas/ChangeLog:
>
> * as.texi (-g): Explicitly mention when .debug_info and .debug_line
> are generated for the DWARF format.
> (Loc): Add that it is an error to both use a .loc directive and
> generate a .debug_line yourself.
> * dwarf2dbg.c (dwarf2_any_loc_directive_seen): New static variable.
> (dwarf2_directive_loc): Set dwarf2_any_loc_directive_seen to TRUE.
> (dwarf2_finish): Check dwarf2_any_loc_directive_seen before emitting
> an error. Only create .debug_line if it is empty (or doesn't exist).
> * testsuite/gas/i386/i386.exp: Add dwarf2-line-{1,2,3,4} when testing
> an elf target.
> * testsuite/gas/i386/dwarf2-line-{1,2,3,4}.{s,d,l}: New test files.
Approved - please apply.
If you are feeling keen, then do please have a go at creating a generic
testcase. If not, then I will make one myself soon.
Cheers
Nick
next reply other threads:[~2020-09-11 15:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 15:45 Nick Clifton [this message]
2020-09-11 18:34 ` Mark Wielaard
2020-09-14 9:45 ` Nick Clifton
2020-09-14 22:43 ` Mark Wielaard
-- strict thread matches above, loose matches on Subject: below --
2020-09-11 12:47 Nick Clifton
2020-09-11 13:51 ` H.J. Lu
2020-09-11 15:40 ` Nick Clifton
2020-09-11 15:46 ` Mark Wielaard
2020-09-11 15:56 ` Nick Clifton
2020-09-14 15:17 ` Nick Clifton
2020-08-26 21:37 Duplicate .debug_lines (Was: [PATCH 5/5] Add --gdwarf-5 to ASM_SPEC) Mark Wielaard
2020-09-07 12:37 ` [PATCH] gas: Don't error when .debug_line already exists, unless .loc was used Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24411cad-fc66-bca6-8122-f3580e2d26c2@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).