public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH] gas: Don't error when .debug_line already exists, unless .loc was used
Date: Mon, 14 Sep 2020 10:45:45 +0100	[thread overview]
Message-ID: <d395a160-fc90-61b6-09ce-70f1c02166fb@redhat.com> (raw)
In-Reply-To: <6479a8f716ee1f34c7812bc2afa4f5c3e4f06990.camel@klomp.org>

Hi Mark,

> Which brings me to another request. This patch (and some of the other
> dwarf5 fixes) as pre-requirements for passing --gdwarf-5 to gas from
> gcc to get full DWARF5 support. Would it be possible to backport these
> to the 2.35 branch so that it can be used with bintuils 2.35.1?
> 
> commit 19d80e5fec548e681c453d15b4ae5b49bc080acc
> bfd: Handle DW_FORM_data16 for .debug_line tables containing MD5
> 
> commit c3757b583d2448a5996e83e374fb96ac7938da35
> Fix the linker's handling of DWARF-5 line number tables.
> 
> commit 4a5700b62f767ed08c97122bad182244700bb4e3
> gas: Handle bad -gdwarf options, just like bad --gdwarf options.
> 
> commit dd216e07a156c19e589fc5f481fe13a256262801
> gas: Use DW_FORM_sec_offset for DWARF version 4 or higher.
> 
> commit b0b3ea7e10443f211267babcac99ac6677d593ce
> gas: Make sure to only add an md5 to a .file when requested.
> 
> commit bdd3b953e24c3d2bc55e06e30e0ef5e0ff829e3f
> gas: Output .debug_rnglists for DWARF 5.
> 
> commit d2a54558074287721ce9e47142f7fa92bda15531
> gas: Output directory and file names in .debug_line_str for DWARF5
> 
> commit edc7a80a9c04667dfa74f90f74bd39827bc372b7
> gas: Don't error when .debug_line already exists, unless .loc was used
> 
> I can do the backports myself if you tell me how.

The how is quite straightforward.  You probably know most of this already
but I am going to include it here just in case:

  0. Request permission to backport the patches.  
     (Permission is granted for the ones listed above).
  1. Checkout the mainline binutils sources from the git repository.
  2. Get the patches for the commits above.
  3. Switch to the binutils-2_35 branch.
  4. Apply the patches.  
     The Changelog changes will probably not apply cleanly, but this is
     OK, because the convention is to create a new changelog entry with
     today's date saying something along the lines of "backport this patch
     from the mainline sources" and then including the original changelog
     entry as a comment in the new changelog.
  5. Test that the patched sources still build.
  6. Commit the changes.

Once this is complete it would be worth sending an email to the list suggesting
that the creation of a 2.35.1 release might be a good thing.  (Assuming of course
that you do think that it would be a good thing).

Cheers
  Nick



  reply	other threads:[~2020-09-14  9:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11 15:45 Nick Clifton
2020-09-11 18:34 ` Mark Wielaard
2020-09-14  9:45   ` Nick Clifton [this message]
2020-09-14 22:43     ` Mark Wielaard
  -- strict thread matches above, loose matches on Subject: below --
2020-09-11 12:47 Nick Clifton
2020-09-11 13:51 ` H.J. Lu
2020-09-11 15:40   ` Nick Clifton
2020-09-11 15:46   ` Mark Wielaard
2020-09-11 15:56     ` Nick Clifton
2020-09-14 15:17     ` Nick Clifton
2020-08-26 21:37 Duplicate .debug_lines (Was: [PATCH 5/5] Add --gdwarf-5 to ASM_SPEC) Mark Wielaard
2020-09-07 12:37 ` [PATCH] gas: Don't error when .debug_line already exists, unless .loc was used Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d395a160-fc90-61b6-09ce-70f1c02166fb@redhat.com \
    --to=nickc@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=mark@klomp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).