From: Simon Marchi <simon.marchi@polymtl.ca>
To: binutils@sourceware.org
Subject: Re: [PATCH] binutils/readelf: fix indentation in process_dynamic_section
Date: Fri, 4 Mar 2022 10:58:46 -0500 [thread overview]
Message-ID: <28007181-d2fd-d2c9-7eb7-c5432bfcf213@polymtl.ca> (raw)
In-Reply-To: <20220225222428.1429817-1-simon.marchi@polymtl.ca>
I pushed this, since it's quite trivial. I added a ChangeLog entry, which I initially
forgot.
Simon
On 2022-02-25 17:24, Simon Marchi wrote:
> Clangd shows a warning about misleading indentation in this file, fix
> it.
>
> Change-Id: I43a7f4f4c75dd080af614222b980526f5debf297
> ---
> binutils/readelf.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/binutils/readelf.c b/binutils/readelf.c
> index b208db593342..16efe1dfd2db 100644
> --- a/binutils/readelf.c
> +++ b/binutils/readelf.c
> @@ -11297,12 +11297,12 @@ the .dynstr section doesn't match the DT_STRTAB and DT_STRSZ tags\n"));
> filedata->file_name,
> filedata->dynamic_addr,
> (unsigned long) filedata->dynamic_nent);
> - else
> - printf (ngettext ("\nDynamic section at offset 0x%lx contains %lu entry:\n",
> - "\nDynamic section at offset 0x%lx contains %lu entries:\n",
> - (unsigned long) filedata->dynamic_nent),
> - filedata->dynamic_addr,
> - (unsigned long) filedata->dynamic_nent);
> + else
> + printf (ngettext ("\nDynamic section at offset 0x%lx contains %lu entry:\n",
> + "\nDynamic section at offset 0x%lx contains %lu entries:\n",
> + (unsigned long) filedata->dynamic_nent),
> + filedata->dynamic_addr,
> + (unsigned long) filedata->dynamic_nent);
> }
> if (do_dynamic)
> printf (_(" Tag Type Name/Value\n"));
>
> base-commit: 820ed8af6a757408873d8955a2db03b0989fdaeb
prev parent reply other threads:[~2022-03-04 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 22:24 Simon Marchi
2022-03-04 15:58 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28007181-d2fd-d2c9-7eb7-c5432bfcf213@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).